Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Issue 2471373005: Pretend the video has no audio track if it is playing as part of autoplay muted. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Pretend the video has no audio track if it is playing as part of autoplay muted. This is to prevent autoplay muted videos to behave as audible videos because they might never be audible as far as the user is concerned. These will avoid taking an audio power blocker for them and also prevent showing a media notification. BUG=638463 R=sandersd@chromium.org,foolip@chromium.org,zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2251073003 Cr-Commit-Position: refs/heads/master@{#429859} (cherry picked from commit 910111369092ad1c3432833491eae73b87a6c33d) Committed: https://chromium.googlesource.com/chromium/src/+/f2f93aa0a8ae4539e6d1499e7f0497c8925504d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -12 lines) Patch
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/AutoplayMutedNotificationTest.java View 1 chunk +161 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/media/session/autoplay-muted.html View 1 chunk +11 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 3 chunks +39 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/autoplay-muted.html View 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 4 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayerClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years, 1 month ago (2016-11-04 13:45:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2f93aa0a8ae4539e6d1499e7f0497c8925504d9.

Powered by Google App Engine
This is Rietveld 408576698