third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl - Issue 2471353004: Implement AudioScheduledSourceNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

Issue 2471353004: Implement AudioScheduledSourceNode (Closed)

Patch Set: Update according to review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h ('K') | « third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

index bc199b8312c9e418694fb8391ea092621f8c4b49..f5c47e7acb061879468eba9e15986207c69435df 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

@@ -29,8 +29,9 @@

Constructor(BaseAudioContext context, optional AudioBufferSourceOptions options),

RaisesException=Constructor,

ActiveScriptWrappable,

+ DependentLifetime

]

-interface AudioBufferSourceNode : AudioSourceNode {

+interface AudioBufferSourceNode : AudioScheduledSourceNode {

[RaisesException=Setter] attribute AudioBuffer buffer;

readonly attribute AudioParam playbackRate;

@@ -40,8 +41,6 @@ interface AudioBufferSourceNode : AudioSourceNode {

attribute double loopStart;

attribute double loopEnd;

- [RaisesException] void start(optional double when, optional double grainOffset, optional double grainDuration);

- [RaisesException] void stop(optional double when);

+ [RaisesException] void start(optional double when = 0, optional double grainOffset, optional double grainDuration);

- attribute EventHandler onended;

};