Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

Issue 2471353004: Implement AudioScheduledSourceNode (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
diff --git a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
index 40e648e0b7b9e7dfd8b6f73ea63347712d607620..900c13558aafa744b03a9e5a4c67f809382e7160 100644
--- a/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
+++ b/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl
@@ -36,19 +36,15 @@ enum OscillatorType {
[
Constructor(BaseAudioContext context, optional OscillatorOptions options),
RaisesException=Constructor,
- ActiveScriptWrappable,
+ ActiveScriptWrappable,
+ DependentLifetime
hongchan 2016/12/01 00:11:22 You can remove ActiveScriptWrappable, DependentLif
Raymond Toy 2016/12/01 18:48:32 Done.
]
-interface OscillatorNode : AudioSourceNode {
+interface OscillatorNode : AudioScheduledSourceNode {
[RaisesException=Setter] attribute OscillatorType type;
readonly attribute AudioParam frequency; // in Hertz
readonly attribute AudioParam detune; // in Cents
- [RaisesException] void start(optional double when);
- [RaisesException] void stop(optional double when);
-
void setPeriodicWave(PeriodicWave periodicWave);
-
- attribute EventHandler onended;
};

Powered by Google App Engine
This is Rietveld 408576698