Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl

Issue 2471353004: Implement AudioScheduledSourceNode (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
diff --git a/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.idl b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
similarity index 55%
copy from third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.idl
copy to third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
index 3773817d8b6e175a6f25ed8d0e2bf666566c03b5..adc0ab90864ea7bcb28630d6f6e1d65fb9419369 100644
--- a/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.idl
+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
@@ -2,14 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// See https://webaudio.github.io/web-audio-api/#ConstantSourceNode
+// See https://webaudio.github.io/web-audio-api/
[
- Constructor(BaseAudioContext context, optional ConstantSourceOptions options),
- RaisesException=Constructor,
ActiveScriptWrappable,
+ DependentLifetime
haraken 2016/11/30 23:54:07 Do you know why we need to add [DependentLifetime]
hongchan 2016/12/01 00:11:22 Yes, according to this description, it seems like
Raymond Toy 2016/12/01 16:35:16 File "/media/rtoy/ssd/chromium/src/third_party/Web
]
-interface ConstantSourceNode : AudioSourceNode {
- readonly attribute AudioParam offset;
+interface AudioScheduledSourceNode : AudioNode {
[RaisesException] void start(optional double when);
[RaisesException] void stop(optional double when);
attribute EventHandler onended;

Powered by Google App Engine
This is Rietveld 408576698