Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: core/fxcrt/fx_system.h

Issue 2471353002: Remove FX_BOOL entirely. (Closed)
Patch Set: Fix nits now rather than later Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fxjs/cfxjse_arguments.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/fx_system.h
diff --git a/core/fxcrt/fx_system.h b/core/fxcrt/fx_system.h
index bcddf1aeeba1906fda651a6d55fa500fbaa8d80e..d3f488a33abc94f29147b65c5cb4a6f85cf30c54 100644
--- a/core/fxcrt/fx_system.h
+++ b/core/fxcrt/fx_system.h
@@ -65,13 +65,6 @@
#ifdef __cplusplus
extern "C" {
-typedef bool FX_BOOL; // Deprecated.
-#ifndef TRUE
-#define TRUE true
-#endif
-#ifndef FALSE
-#define FALSE false
-#endif
#endif // __cplusplus
typedef void* FX_POSITION; // Keep until fxcrt containers gone
@@ -90,11 +83,6 @@ typedef wchar_t FX_WCHAR; // Keep, maybe bad platform wchars.
// TODO(palmer): it should be a |size_t|, or at least unsigned.
typedef int FX_STRSIZE;
-#ifdef __cplusplus
-static_assert(TRUE == true, "true_needs_to_be_true");
-static_assert(FALSE == false, "false_needs_to_be_false");
-#endif
-
#ifndef ASSERT
#ifndef NDEBUG
#define ASSERT assert
« no previous file with comments | « no previous file | fxjs/cfxjse_arguments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698