Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: fxjs/cfxjse_class.cpp

Issue 2471353002: Remove FX_BOOL entirely. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fxjs/cfxjse_class.cpp
diff --git a/fxjs/cfxjse_class.cpp b/fxjs/cfxjse_class.cpp
index c2c8e5fec22268a19dd2ad279c7336c1bb474220..303869b6fadc315ca3c63905d22d44a138ba0fac 100644
--- a/fxjs/cfxjse_class.cpp
+++ b/fxjs/cfxjse_class.cpp
@@ -151,7 +151,7 @@ void DynPropGetterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
int32_t nPropType =
lpClass->dynPropTypeGetter == nullptr
? FXJSE_ClassPropType_Property
- : lpClass->dynPropTypeGetter(pObject, szPropName, FALSE);
+ : lpClass->dynPropTypeGetter(pObject, szPropName, false);
if (nPropType == FXJSE_ClassPropType_Property) {
if (lpClass->dynPropGetter)
lpClass->dynPropGetter(pObject, szPropName, pValue);
@@ -187,38 +187,38 @@ void DynPropSetterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
int32_t nPropType =
lpClass->dynPropTypeGetter == nullptr
? FXJSE_ClassPropType_Property
- : lpClass->dynPropTypeGetter(pObject, szPropName, FALSE);
+ : lpClass->dynPropTypeGetter(pObject, szPropName, false);
if (nPropType != FXJSE_ClassPropType_Method) {
if (lpClass->dynPropSetter)
lpClass->dynPropSetter(pObject, szPropName, pValue);
}
}
-FX_BOOL DynPropQueryAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
- CFXJSE_Value* pObject,
- const CFX_ByteStringC& szPropName) {
+bool DynPropQueryAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
+ CFXJSE_Value* pObject,
+ const CFX_ByteStringC& szPropName) {
ASSERT(lpClass);
int32_t nPropType =
lpClass->dynPropTypeGetter == nullptr
? FXJSE_ClassPropType_Property
- : lpClass->dynPropTypeGetter(pObject, szPropName, TRUE);
+ : lpClass->dynPropTypeGetter(pObject, szPropName, true);
return nPropType != FXJSE_ClassPropType_None;
}
-FX_BOOL DynPropDeleterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
- CFXJSE_Value* pObject,
- const CFX_ByteStringC& szPropName) {
+bool DynPropDeleterAdapter(const FXJSE_CLASS_DESCRIPTOR* lpClass,
+ CFXJSE_Value* pObject,
+ const CFX_ByteStringC& szPropName) {
ASSERT(lpClass);
int32_t nPropType =
lpClass->dynPropTypeGetter == nullptr
? FXJSE_ClassPropType_Property
- : lpClass->dynPropTypeGetter(pObject, szPropName, FALSE);
+ : lpClass->dynPropTypeGetter(pObject, szPropName, false);
if (nPropType != FXJSE_ClassPropType_Method) {
if (lpClass->dynPropDeleter)
return lpClass->dynPropDeleter(pObject, szPropName);
- return nPropType == FXJSE_ClassPropType_Property ? FALSE : TRUE;
+ return nPropType == FXJSE_ClassPropType_Property ? false : true;
Lei Zhang 2016/11/02 23:13:09 For later, get rid of the ternary operator.
Tom Sepez 2016/11/02 23:17:50 Done.
}
- return FALSE;
+ return false;
}
void NamedPropertyQueryCallback(
@@ -315,7 +315,7 @@ void NamedPropertyEnumeratorCallback(
CFXJSE_Class* CFXJSE_Class::Create(
CFXJSE_Context* lpContext,
const FXJSE_CLASS_DESCRIPTOR* lpClassDefinition,
- FX_BOOL bIsJSGlobal) {
+ bool bIsJSGlobal) {
if (!lpContext || !lpClassDefinition)
return nullptr;
« no previous file with comments | « fxjs/cfxjse_class.h ('k') | fxjs/cfxjse_context.h » ('j') | fxjs/cfxjse_context.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698