Remove FX_BOOL entirely.

fxjs/cfxjse_context.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fxjs/cfxjse_context.h"
 
 #include "fxjs/cfxjse_class.h"
 #include "fxjs/cfxjse_value.h"
@@ skipping 138 matching lines @@
 // static
 CFXJSE_Context* CFXJSE_Context::Create(
     v8::Isolate* pIsolate,
     const FXJSE_CLASS_DESCRIPTOR* lpGlobalClass,
     CFXJSE_HostObject* lpGlobalObject) {
   CFXJSE_ScopeUtil_IsolateHandle scope(pIsolate);
   CFXJSE_Context* pContext = new CFXJSE_Context(pIsolate);
   CFXJSE_Class* lpGlobalClassObj = nullptr;
   v8::Local<v8::ObjectTemplate> hObjectTemplate;
   if (lpGlobalClass) {
-    lpGlobalClassObj = CFXJSE_Class::Create(pContext, lpGlobalClass, TRUE);
+    lpGlobalClassObj = CFXJSE_Class::Create(pContext, lpGlobalClass, true);
     ASSERT(lpGlobalClassObj);
     v8::Local<v8::FunctionTemplate> hFunctionTemplate =
         v8::Local<v8::FunctionTemplate>::New(pIsolate,
                                              lpGlobalClassObj->m_hTemplate);
     hObjectTemplate = hFunctionTemplate->InstanceTemplate();
   } else {
     hObjectTemplate = v8::ObjectTemplate::New(pIsolate);
     hObjectTemplate->SetInternalFieldCount(1);
   }
   hObjectTemplate->Set(
@@ skipping 25 matching lines @@
   v8::Local<v8::Object> hGlobalObject = hContext->Global();
   pValue->ForceSetValue(hGlobalObject);
 
   return pValue;
 }
 
 void CFXJSE_Context::EnableCompatibleMode() {
   ExecuteScript(szCompatibleModeScript, nullptr, nullptr);
 }
 
-FX_BOOL CFXJSE_Context::ExecuteScript(const FX_CHAR* szScript,
-                                      CFXJSE_Value* lpRetValue,
-                                      CFXJSE_Value* lpNewThisObject) {
+bool CFXJSE_Context::ExecuteScript(const FX_CHAR* szScript,
+                                   CFXJSE_Value* lpRetValue,
+                                   CFXJSE_Value* lpNewThisObject) {
   CFXJSE_ScopeUtil_IsolateHandleContext scope(this);
   v8::TryCatch trycatch(m_pIsolate);
   v8::Local<v8::String> hScriptString =
       v8::String::NewFromUtf8(m_pIsolate, szScript);
   if (!lpNewThisObject) {
     v8::Local<v8::Script> hScript = v8::Script::Compile(hScriptString);
     if (!trycatch.HasCaught()) {
       v8::Local<v8::Value> hValue = hScript->Run();
       if (!trycatch.HasCaught()) {
         if (lpRetValue) {
           lpRetValue->m_hValue.Reset(m_pIsolate, hValue);
         }
-        return TRUE;
+        return true;
       }
     }
     if (lpRetValue) {
       lpRetValue->m_hValue.Reset(m_pIsolate,
                                  FXJSE_CreateReturnValue(m_pIsolate, trycatch));
     }
-    return FALSE;
+    return false;
   } else {

[Lei Zhang, 2016/11/02 23:13:09]

For later - else after return.

[Tom Sepez, 2016/11/02 23:17:50]

Done.

     v8::Local<v8::Value> hNewThis =
         v8::Local<v8::Value>::New(m_pIsolate, lpNewThisObject->m_hValue);
     ASSERT(!hNewThis.IsEmpty());
     v8::Local<v8::Script> hWrapper =
         v8::Script::Compile(v8::String::NewFromUtf8(
             m_pIsolate, "(function () { return eval(arguments[0]); })"));
     v8::Local<v8::Value> hWrapperValue = hWrapper->Run();
     ASSERT(hWrapperValue->IsFunction());
     v8::Local<v8::Function> hWrapperFn = hWrapperValue.As<v8::Function>();
     if (!trycatch.HasCaught()) {
       v8::Local<v8::Value> rgArgs[] = {hScriptString};
       v8::Local<v8::Value> hValue =
           hWrapperFn->Call(hNewThis.As<v8::Object>(), 1, rgArgs);
       if (!trycatch.HasCaught()) {
         if (lpRetValue) {
           lpRetValue->m_hValue.Reset(m_pIsolate, hValue);
         }
-        return TRUE;
+        return true;
       }
     }
     if (lpRetValue) {
       lpRetValue->m_hValue.Reset(m_pIsolate,
                                  FXJSE_CreateReturnValue(m_pIsolate, trycatch));
     }
-    return FALSE;
+    return false;
   }
 }