Remove FX_BOOL entirely.

Remove FX_BOOL entirely.

FX_BOOL was a type just like a regular C++ bool, except that it
took 4x the space and frequently was used to hold values besides
true or false.

Committed: https://pdfium.googlesource.com/pdfium/+/304bb91238d6909cb5e170f8fc483aa7862558d5

[Tom Sepez, 2016-11-02 22:51:08]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-02 22:51:47]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-11-02 22:51:47]

Lei, fx_system.h has manual edits.  Ta Da !!!

[commit-bot: I haz the power, 2016-11-02 23:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:07:45]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-02 23:13:09]

Let's give Chromium's PDFium roller a chance to roll the prior CLs before
landing this one.

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_class.cpp
File fxjs/cfxjse_class.cpp (right):

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_class.cpp#newco...
fxjs/cfxjse_class.cpp:219: return nPropType == FXJSE_ClassPropType_Property ?
false : true;
For later, get rid of the ternary operator.

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_context.cpp
File fxjs/cfxjse_context.cpp (right):

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_context.cpp#new...
fxjs/cfxjse_context.cpp:228: } else {
For later - else after return.

[Lei Zhang, 2016-11-02 23:13:14]

lgtm

[Tom Sepez, 2016-11-02 23:17:50]

Fixed nits now, waiting for roller.

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_class.cpp
File fxjs/cfxjse_class.cpp (right):

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_class.cpp#newco...
fxjs/cfxjse_class.cpp:219: return nPropType == FXJSE_ClassPropType_Property ?
false : true;
On 2016/11/02 23:13:09, Lei Zhang wrote:
> For later, get rid of the ternary operator.

Done.

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_context.cpp
File fxjs/cfxjse_context.cpp (right):

https://codereview.chromium.org/2471353002/diff/1/fxjs/cfxjse_context.cpp#new...
fxjs/cfxjse_context.cpp:228: } else {
On 2016/11/02 23:13:09, Lei Zhang wrote:
> For later - else after return.

Done.

[dsinclair, 2016-11-03 12:54:47]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-11-03 12:54:47]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-03 12:54:48]

lgtm

Roller is done for the other CLs. Sending to the CQ.

[dsinclair, 2016-11-03 12:54:48]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2471353002/#ps20001
(title: "Fix nits now rather than later")

[commit-bot: I haz the power, 2016-11-03 12:54:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 13:10:29]

Description was changed from

==========
Remove FX_BOOL entirely.

FX_BOOL was a type just like a regular C++ bool, except that it
took 4x the space and frequently was used to hold values besides
true or false.
==========

to

==========
Remove FX_BOOL entirely.

FX_BOOL was a type just like a regular C++ bool, except that it
took 4x the space and frequently was used to hold values besides
true or false.

Committed:
https://pdfium.googlesource.com/pdfium/+/304bb91238d6909cb5e170f8fc483aa78625...
==========

[commit-bot: I haz the power, 2016-11-03 13:10:31]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/304bb91238d6909cb5e170f8fc483aa78625...