Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2471343002: Move to the new mx_vmo_syscall argument order (Closed)

Created:
4 years, 1 month ago by kulakowski
Modified:
4 years, 1 month ago
Reviewers:
abarth, kulakowski1, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move to the new mx_vmo_syscall argument order #

Total comments: 1

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/virtual_memory_fuchsia.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kulakowski1
ptal This should be landed when https://fuchsia-review.googlesource.com/c/13838 lands.
4 years, 1 month ago (2016-11-02 22:16:35 UTC) #2
abarth
LGTM
4 years, 1 month ago (2016-11-02 22:18:24 UTC) #3
zra
https://codereview.chromium.org/2471343002/diff/20001/runtime/vm/virtual_memory_fuchsia.cc File runtime/vm/virtual_memory_fuchsia.cc (right): https://codereview.chromium.org/2471343002/diff/20001/runtime/vm/virtual_memory_fuchsia.cc#newcode29 runtime/vm/virtual_memory_fuchsia.cc:29: mx_status_t status = mx_vmo_create(size, 0u, &mx); mx -> vmo?
4 years, 1 month ago (2016-11-02 22:20:06 UTC) #4
kulakowski1
On 2016/11/02 22:20:06, zra wrote: > https://codereview.chromium.org/2471343002/diff/20001/runtime/vm/virtual_memory_fuchsia.cc > File runtime/vm/virtual_memory_fuchsia.cc (right): > > https://codereview.chromium.org/2471343002/diff/20001/runtime/vm/virtual_memory_fuchsia.cc#newcode29 > ...
4 years, 1 month ago (2016-11-03 21:04:14 UTC) #5
abarth-chromium
4 years, 1 month ago (2016-11-03 21:17:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
913b592a4ee7222059f0357a9fdc4a7bb0936b41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698