Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: build/sanitizers/sanitizer_options.cc

Issue 2471333003: NOSUBMIT: Reduce ASAN memory consumption on 32-bit Intel Chrome OS (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/platform_thread_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/sanitizers/sanitizer_options.cc
diff --git a/build/sanitizers/sanitizer_options.cc b/build/sanitizers/sanitizer_options.cc
index 39fa1403c975f379160571fd86c0ef339d111202..97b4f88c631af432885a4efd3ea21509e4452c1c 100644
--- a/build/sanitizers/sanitizer_options.cc
+++ b/build/sanitizers/sanitizer_options.cc
@@ -58,7 +58,17 @@ void _sanitizer_options_link_helper() { }
// so the slow unwinder may not work properly.
// detect_stack_use_after_return=1 - use fake stack to delay the reuse of
// stack allocations and detect stack-use-after-return errors.
-#if defined(OS_LINUX)
+// quarantine_size_mb=16 - reduce size of quarantine used to detect use-after-
+// free errors. Increases risk of false negatives but uses less RAM.
+#if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86)
+// On 32-bit Intel Chrome OS try to reduce ASAN memory consumption with
+// quarantine_size_mb.
+const char kAsanDefaultOptions[] =
+ "symbolize=1 check_printf=1 use_sigaltstack=1 "
+ "detect_leaks=0 strip_path_prefix=/../../ fast_unwind_on_fatal=1 "
+ "detect_stack_use_after_return=0 "
+ "quarantine_size_mb=16 ";
+#elif defined(OS_LINUX)
#if defined(GOOGLE_CHROME_BUILD)
// Default AddressSanitizer options for the official build. These do not affect
// tests on buildbots (which don't set GOOGLE_CHROME_BUILD) or non-official
« no previous file with comments | « base/threading/platform_thread_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698