Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2471323002: Retesting reference range based on the same criteria as other revisions. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Retesting reference range based on the same criteria as other revisions. I am removing the timeout approach to be consistent with how other revisions are re-tested. Basically delegating the logic to compare_samples, but having a maximum number of tests to be run to avoid the infinite loop. Also, I am cleaning up the structure of nested steps. R=dtu@chromium.org BUG=661777 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d7af4f01660860d2e2faf7662b8084caef6eb440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12478 lines, -3305 lines) Patch
M scripts/slave/recipe_modules/auto_bisect_staging/bisector.py View 3 chunks +19 lines, -20 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json View 151 chunks +1248 lines, -1040 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_basic_device.json View 2 chunks +2918 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json View 224 chunks +5375 lines, -2237 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json View 2 chunks +2918 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 1 month ago (2016-11-02 21:46:37 UTC) #1
dtu
lgtm
4 years, 1 month ago (2016-11-02 22:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471323002/1
4 years, 1 month ago (2016-11-02 22:40:05 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:52:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d7af4f01660860d2e2fa...

Powered by Google App Engine
This is Rietveld 408576698