third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2471283004: [css-grid] Fix simplified layout of positioned grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2471283004: [css-grid] Fix simplified layout of positioned grid items (Closed)

Patch Set: Remove unneeded line in test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index cd563271ebf381337a30ff9063af614baaaaaefb..e70d9c55605b6b0cafc97894bbeccf6caed3cdb2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -176,8 +176,9 @@ class LayoutGrid final : public LayoutBlock {

void layoutGridItems(GridSizingData&);

void prepareChildForPositionedLayout(LayoutBox&);

- void layoutPositionedObjects(bool relayoutChildren,

- PositionedLayoutBehavior = DefaultLayout);

+ void layoutPositionedObjects(

+ bool relayoutChildren,

+ PositionedLayoutBehavior = DefaultLayout) override;

void offsetAndBreadthForPositionedChild(const LayoutBox&,

GridTrackSizingDirection,

LayoutUnit& offset,