Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2471283004: [css-grid] Fix simplified layout of positioned grid items (Closed)
Patch Set: New version Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutGrid.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 05a01b709fbfee65abbd54397c163e4667c2d148..5c7b314650e7ed0cd63af93142f3511fa9b5feb4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -475,7 +475,10 @@ void LayoutGrid::repeatTracksSizingIfNeeded(GridSizingData& sizingData,
void LayoutGrid::layoutBlock(bool relayoutChildren) {
ASSERT(needsLayout());
- if (!relayoutChildren && simplifiedLayout())
+ // We cannot perform a simplifiedLayout() on a dirty grid that
+ // has positioned items to be layout.
mstensho (USE GERRIT) 2016/11/04 09:47:34 "to be laid out"
Manuel Rego 2016/11/04 09:57:56 Acknowledged.
+ if (!relayoutChildren && !(m_gridIsDirty && posChildNeedsLayout()) &&
mstensho (USE GERRIT) 2016/11/04 09:47:34 Nit: Augustus de Morgan might write that middle ex
Manuel Rego 2016/11/04 09:57:56 Done.
+ simplifiedLayout())
return;
SubtreeLayoutScope layoutScope(*this);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutGrid.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698