[css-grid] Fix simplified layout of positioned grid items

third_party/WebKit/Source/core/layout/LayoutBlock.h

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index 6058995f0636aa0ada54bb94a91b316d4f0c2cf9..6967f0655b2abc3b531e3629c339eb8ab47f4f9a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -358,8 +358,9 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
     ForcedLayoutAfterContainingBlockMoved
   };
 
-  void layoutPositionedObjects(bool relayoutChildren,
-                               PositionedLayoutBehavior = DefaultLayout);
+  virtual void layoutPositionedObjects(

[mstensho (USE GERRIT), 2016/11/04 08:49:12]

This shouldn't be necessary.

[Manuel Rego, 2016/11/04 09:29:17]

Mmmm, we need that LayoutGrid::layoutPositionedObjects() is called
from LayoutBlock::simplifiedLayout().
If we don't mark the function as virtual, this won't happen, only
LayoutBlock::layoutPositionedObjects() will be called
(and the positioned objects won't be properly placed inside the grid).

Am I missing something?

[mstensho (USE GERRIT), 2016/11/04 09:47:34]

Duh, no. *I* was missing something. Sorry. This needs to remain virtual.

+      bool relayoutChildren,
+      PositionedLayoutBehavior = DefaultLayout);
   void markFixedPositionObjectForLayoutIfNeeded(LayoutObject* child,
                                                 SubtreeLayoutScope&);
 
@@ -421,7 +422,7 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {
 
   virtual bool hasLineIfEmpty() const;
 
-  bool simplifiedLayout();
+  virtual bool simplifiedLayout();

[mstensho (USE GERRIT), 2016/11/04 08:49:12]

Ditto.

[Manuel Rego, 2016/11/04 09:29:17]

True for this case, actually as @cbiesinger suggested
I'm no longer overriding this function in the new version of the patch.

   virtual void simplifiedNormalFlowLayout();
 
  public: