Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1838)

Issue 2471283003: Re-enabling tests that seem to not be flaky (Closed)

Created:
4 years, 1 month ago by amaralp
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enabling tests that seem to not be flaky These tests seem to not be flaky after crrev.com/2468043002 landed. I've run each of these tests 400+ times locally on my Nexus 6P (Android M) and ~40 times on my Nexus 4 (Android K) and had no failures. BUG=592428 Committed: https://crrev.com/8baf53f912098f36d71772ed240238520f7a6249 Cr-Commit-Position: refs/heads/master@{#429640}

Patch Set 1 #

Patch Set 2 : Disabled bug and fixed a potential race condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 6 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
amaralp
PTAL
4 years, 1 month ago (2016-11-02 23:58:15 UTC) #2
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-03 00:57:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471283003/20001
4 years, 1 month ago (2016-11-03 17:39:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 17:46:33 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:14:21 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8baf53f912098f36d71772ed240238520f7a6249
Cr-Commit-Position: refs/heads/master@{#429640}

Powered by Google App Engine
This is Rietveld 408576698