Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2471263005: CHECK for re-addition of indirect objects (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

CHECK for re-addition of indirect objects Committed: https://pdfium.googlesource.com/pdfium/+/1d08c50d1c20798001a1944e8a1fd76d09643ef1

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_indirect_object_holder.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Tom Sepez
Lei, this is another way in which onwership could get confused.
4 years, 1 month ago (2016-11-04 21:00:40 UTC) #10
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-04 22:25:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471263005/20001
4 years, 1 month ago (2016-11-04 22:44:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/1d08c50d1c20798001a1944e8a1fd76d09643ef1
4 years, 1 month ago (2016-11-04 22:45:06 UTC) #15
Tom Sepez
4 years, 1 month ago (2016-11-04 22:45:26 UTC) #16
Message was sent while issue was closed.
On 2016/11/04 22:25:02, Lei Zhang wrote:
> lgtm

FYI, I intend to soften this before we branch for beta, but I want to see this
bake on dev for a bit.

Powered by Google App Engine
This is Rietveld 408576698