Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h

Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti… (Closed)
Patch Set: resolve code review comments from mlamouri Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h
diff --git a/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h b/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h
index 055de84f30d1756611ca0f9fcfacabec71d892d8..7a94e65078b7d2621f90b2f838d5e392bba2ebca 100644
--- a/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h
+++ b/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h
@@ -7,6 +7,7 @@
#include "platform/heap/Handle.h"
#include "public/platform/WebCallbacks.h"
+#include "public/platform/modules/presentation/WebPresentationConnectionCallbacks.h"
#include "wtf/Noncopyable.h"
namespace blink {
@@ -20,17 +21,22 @@ struct WebPresentationSessionInfo;
// underlying promise. It takes the PresentationConnection object that
// originated the call in its constructor and will resolve underlying promise
// with that object.
+// TODO(crbug.com/684111): Combine ExistingPresentationConnectionCallbacks with
+// PresentationConnectionCallbacks
class ExistingPresentationConnectionCallbacks final
- : public WebCallbacks<const WebPresentationSessionInfo&,
- const WebPresentationError&> {
+ : public WebPresentationConnectionCallbacks {
public:
ExistingPresentationConnectionCallbacks(ScriptPromiseResolver*,
PresentationConnection*);
~ExistingPresentationConnectionCallbacks() override = default;
+ // WebCallbacks implementation
void onSuccess(const WebPresentationSessionInfo&) override;
void onError(const WebPresentationError&) override;
+ // WebPresentationConnectionCallbacks implementation
+ WebPresentationConnection* getConnection() override;
+
private:
Persistent<ScriptPromiseResolver> m_resolver;
Persistent<PresentationConnection> m_connection;
« no previous file with comments | « content/test/BUILD.gn ('k') | third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698