third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp - Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti… (Closed)

Patch Set: resolve code review comments from Derek and Mark Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/exported/WebPresentationConnectionCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp b/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

new file mode 100644

index 0000000000000000000000000000000000000000..f220d6fa5a077905abad27dca7b2a653fd51ddd1

--- /dev/null

+++ b/third_party/WebKit/Source/platform/exported/WebPresentationConnection.cpp

@@ -0,0 +1,11 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+#include "public/platform/modules/presentation/WebPresentationConnection.h"

+// This WebPresentationConnection.cpp, which includes only

+// WebPresentationConnection.h, should be in Source/platform/exported,

+// because WebPresentationController is not compiled without this cpp.

+// So if we don't have this cpp, we will see unresolved symbol error

+// when constructor/destructor's address is required.