third_party/WebKit/Source/modules/presentation/PresentationController.cpp - Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti… (Closed)

Patch Set: resolve code review comments from Derek and Mark Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationController.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationReceiver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

index f661e7bd12d1afd8a01214d2af31566982b67cfd..5f4e15b8b0aacf4b3dd3e8191c8dfa5b23bb33a3 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

@@ -66,12 +66,13 @@ DEFINE_TRACE(PresentationController) {

ContextLifecycleObserver::trace(visitor);

}

-void PresentationController::didStartDefaultSession(

+WebPresentationConnection* PresentationController::didStartDefaultSession(

const WebPresentationSessionInfo& sessionInfo) {

if (!m_presentation || !m_presentation->defaultRequest())

- return;

- PresentationConnection::take(this, sessionInfo,

- m_presentation->defaultRequest());

+ return nullptr;

+ return PresentationConnection::take(this, sessionInfo,

+ m_presentation->defaultRequest());

}

void PresentationController::didChangeSessionState(