Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2746)

Unified Diff: content/renderer/presentation/presentation_connection_client.h

Issue 2471263003: [Presentation API] (4th)(1-UA blink side) Add WebPresentationConnection and WebPresentationConnecti… (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_connection_client.h
diff --git a/content/renderer/presentation/presentation_connection_client.h b/content/renderer/presentation/presentation_connection_client.h
index f8e0bac00034b04684557338fcb418b5edb9c314..0f7e9de53cfa0d00e5b51105a0505e290752a994 100644
--- a/content/renderer/presentation/presentation_connection_client.h
+++ b/content/renderer/presentation/presentation_connection_client.h
@@ -20,17 +20,28 @@ class CONTENT_EXPORT PresentationConnectionClient
public:
explicit PresentationConnectionClient(
blink::mojom::PresentationSessionInfoPtr session_info);
- explicit PresentationConnectionClient(const GURL& url,
- const mojo::String& id);
+
+ // Creates a PresentationConnectionClient for a 1-UA presentation.
+ // |session_info|: contains presentation ID and URL info
+ // |proxy|: Proxy to blink PresentationConnection object in current render
+ // process. Ownership is passed to this class.
+ PresentationConnectionClient(
+ blink::mojom::PresentationSessionInfoPtr session_info,
+ std::unique_ptr<blink::WebPresentationConnectionProxy> proxy);
~PresentationConnectionClient() override;
// WebPresentationConnectionClient implementation.
blink::WebURL getUrl() override;
blink::WebString getId() override;
+ // Returns proxy passed into this class. It will transfer ownership of
+ // |proxy_| to calling object (PresentationConnection).
mark a. foltz 2016/11/16 01:16:39 I would just say, "Transfers ownership of returned
zhaobin 2016/11/23 22:52:29 Done.
+ std::unique_ptr<blink::WebPresentationConnectionProxy> takeProxy() override;
+
private:
blink::WebURL url_;
blink::WebString id_;
+ std::unique_ptr<blink::WebPresentationConnectionProxy> proxy_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698