Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2471243002: DevTools: Consolidate completion code into JavaScriptAutocomplete.js (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Consolidate completion code into JavaScriptAutocomplete.js BUG=660941 Committed: https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f Cr-Commit-Position: refs/heads/master@{#429537}

Patch Set 1 #

Patch Set 2 : merge #

Messages

Total messages: 21 (10 generated)
einbinder
ptal this is the formatted version of https://codereview.chromium.org/2468493004
4 years, 1 month ago (2016-11-02 19:48:52 UTC) #2
lushnikov
rs lgtm (since this is a reformat of other patch)
4 years, 1 month ago (2016-11-02 20:39:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471243002/1
4 years, 1 month ago (2016-11-02 20:57:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/172996)
4 years, 1 month ago (2016-11-02 23:07:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471243002/1
4 years, 1 month ago (2016-11-02 23:22:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295451)
4 years, 1 month ago (2016-11-02 23:30:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471243002/20001
4 years, 1 month ago (2016-11-03 02:56:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 04:57:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471243002/20001
4 years, 1 month ago (2016-11-03 07:39:00 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 08:11:02 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 08:14:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b667bbde4508a08433cdc5d63f68f6c475231a6f
Cr-Commit-Position: refs/heads/master@{#429537}

Powered by Google App Engine
This is Rietveld 408576698