|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by dschuyler Modified:
4 years, 1 month ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] right align cookies filter and remove all buttons
This CL moves the remove cookies button and the cookies site filter to
the end of the row. This was specifically approved by Alan since it
differs from the current mocks (i.e. the mocks should be updated to
reflect this CL).
This CL will also clear the site search filter after all the items
in the search are deleted.
BUG=660192
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/b2fc43703a355316c9493a843ca904c5fb65acb2
Cr-Commit-Position: refs/heads/master@{#429694}
Patch Set 1 #Patch Set 2 : removed extra div #Patch Set 3 : added margin; clearing filter after delete #
Total comments: 2
Patch Set 4 : closure fix #
Messages
Total messages: 27 (19 generated)
Description was changed from ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). BUG=660192 ========== to ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
can i have before and after screenshots or demo?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
added margin; clearing filter after delete
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
lgtm https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/site_data.js (right): https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/site_data.js:121: this.$.filter.setValue(''); you need to cast this.$.filter
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/site_data.js (right): https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/site_data.js:121: this.$.filter.setValue(''); On 2016/11/03 06:31:34, Dan Beam wrote: > you need to cast this.$.filter Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2471223002/#ps60001 (title: "closure fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b2fc43703a355316c9493a843ca904c5fb65acb2 Cr-Commit-Position: refs/heads/master@{#429694} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/b2fc43703a355316c9493a843ca904c5fb65acb2 Cr-Commit-Position: refs/heads/master@{#429694} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
