Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2471223002: [MD settings] right align cookies filter and remove all buttons (Closed)

Created:
4 years, 1 month ago by dschuyler
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] right align cookies filter and remove all buttons This CL moves the remove cookies button and the cookies site filter to the end of the row. This was specifically approved by Alan since it differs from the current mocks (i.e. the mocks should be updated to reflect this CL). This CL will also clear the site search filter after all the items in the search are deleted. BUG=660192 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b2fc43703a355316c9493a843ca904c5fb65acb2 Cr-Commit-Position: refs/heads/master@{#429694}

Patch Set 1 #

Patch Set 2 : removed extra div #

Patch Set 3 : added margin; clearing filter after delete #

Total comments: 2

Patch Set 4 : closure fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M chrome/browser/resources/settings/site_settings/compiled_resources2.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 2 1 chunk +16 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (19 generated)
dschuyler
4 years, 1 month ago (2016-11-02 18:56:44 UTC) #5
Dan Beam
can i have before and after screenshots or demo?
4 years, 1 month ago (2016-11-02 19:06:07 UTC) #7
dschuyler
added margin; clearing filter after delete
4 years, 1 month ago (2016-11-02 19:32:31 UTC) #10
Dan Beam
lgtm https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resources/settings/site_settings/site_data.js File chrome/browser/resources/settings/site_settings/site_data.js (right): https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resources/settings/site_settings/site_data.js#newcode121 chrome/browser/resources/settings/site_settings/site_data.js:121: this.$.filter.setValue(''); you need to cast this.$.filter
4 years, 1 month ago (2016-11-03 06:31:34 UTC) #15
dschuyler
https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resources/settings/site_settings/site_data.js File chrome/browser/resources/settings/site_settings/site_data.js (right): https://codereview.chromium.org/2471223002/diff/40001/chrome/browser/resources/settings/site_settings/site_data.js#newcode121 chrome/browser/resources/settings/site_settings/site_data.js:121: this.$.filter.setValue(''); On 2016/11/03 06:31:34, Dan Beam wrote: > you ...
4 years, 1 month ago (2016-11-03 18:24:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471223002/60001
4 years, 1 month ago (2016-11-03 20:54:20 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-03 21:01:17 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:03:39 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b2fc43703a355316c9493a843ca904c5fb65acb2
Cr-Commit-Position: refs/heads/master@{#429694}

Powered by Google App Engine
This is Rietveld 408576698