Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2471193002: Fix double-move of SkColorSpace (Closed)

Created:
4 years, 1 month ago by ccameron
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix double-move of SkColorSpace I allowed std::move(colorSpace) to be called twice, resulting in in the second result being null. TBR=junov BUG=44872 Committed: https://crrev.com/14bf9e84af49ea02296fba3083f6e91db1def841 Cr-Commit-Position: refs/heads/master@{#429403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471193002/1
4 years, 1 month ago (2016-11-02 17:43:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 21:21:59 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:23:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14bf9e84af49ea02296fba3083f6e91db1def841
Cr-Commit-Position: refs/heads/master@{#429403}

Powered by Google App Engine
This is Rietveld 408576698