Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2471183004: Updates comments in the src files to remove gender specific terms. (Closed)

Created:
4 years, 1 month ago by kennetht
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asanka, alemate+watch_chromium.org, mcasas+watch+vc_chromium.org, achuith+watch_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, davemoore+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates comments in the src files to remove gender specific terms. This removes 'he', 'she', 'his' and 'her' from the comments. BUG=542537 Committed: https://crrev.com/5b9d52e8a6ec9c11a675bae21c7d1b0448689fb6 Cr-Commit-Position: refs/heads/master@{#429800}

Patch Set 1 #

Messages

Total messages: 24 (14 generated)
kennetht
I've started working through the files and here's the first batch.
4 years, 1 month ago (2016-11-03 06:27:43 UTC) #2
kcarattini
lgtm Thanks! Please add bug 542537 to your cl.
4 years, 1 month ago (2016-11-03 06:34:28 UTC) #3
benwells
yes, lgtm and thanks! Next step is to add owner(s) who together own all the ...
4 years, 1 month ago (2016-11-03 06:59:20 UTC) #4
vabr (Chromium)
chrome/browser/password_manager/save_password_infobar_delegate_android.h LGTM, thanks for this improvement! Cheers, Vaclav
4 years, 1 month ago (2016-11-03 14:43:48 UTC) #6
kennetht
Adding thestig@ for OWNERS approval.
4 years, 1 month ago (2016-11-04 00:38:52 UTC) #12
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-04 00:50:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471183004/1
4 years, 1 month ago (2016-11-04 04:07:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471183004/1
4 years, 1 month ago (2016-11-04 04:09:56 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 05:40:55 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 05:43:25 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b9d52e8a6ec9c11a675bae21c7d1b0448689fb6
Cr-Commit-Position: refs/heads/master@{#429800}

Powered by Google App Engine
This is Rietveld 408576698