components/sync/engine/passive_model_worker.h - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine/passive_model_worker.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #23 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine/passive_model_worker.h

diff --git a/components/sync/engine/passive_model_worker.h b/components/sync/engine/passive_model_worker.h

index a8ddcfdfb690903e3582c5420ee91cae3e9ca0a5..999a587bbc9c5c478417133f2a4a319da1d123f5 100644

--- a/components/sync/engine/passive_model_worker.h

+++ b/components/sync/engine/passive_model_worker.h

@@ -5,7 +5,6 @@

#ifndef COMPONENTS_SYNC_ENGINE_PASSIVE_MODEL_WORKER_H_

#define COMPONENTS_SYNC_ENGINE_PASSIVE_MODEL_WORKER_H_

-#include "base/compiler_specific.h"

#include "base/macros.h"

#include "components/sync/base/syncer_error.h"

#include "components/sync/engine/model_safe_worker.h"

@@ -17,10 +16,9 @@ namespace syncer {

// thread).

class PassiveModelWorker : public ModelSafeWorker {

public:

- explicit PassiveModelWorker(WorkerLoopDestructionObserver* observer);

+ PassiveModelWorker();

// ModelSafeWorker implementation. Called on the sync thread.

- void RegisterForLoopDestruction() override;

ModelSafeGroup GetModelSafeGroup() override;

protected: