components/sync/driver/fake_sync_client.h - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/fake_sync_client.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #23 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/fake_sync_client.h

diff --git a/components/sync/driver/fake_sync_client.h b/components/sync/driver/fake_sync_client.h

index 8e0884f1d6dbff3efea73dbe3c1547b8df141209..b68999edbfc2477edc1fbbcb6e3db42f30fd09ec 100644

--- a/components/sync/driver/fake_sync_client.h

+++ b/components/sync/driver/fake_sync_client.h

@@ -42,8 +42,7 @@ class FakeSyncClient : public SyncClient {

base::WeakPtr<ModelTypeSyncBridge> GetSyncBridgeForModelType(

ModelType type) override;

scoped_refptr<ModelSafeWorker> CreateModelWorkerForGroup(

- ModelSafeGroup group,

- WorkerLoopDestructionObserver* observer) override;

+ ModelSafeGroup group) override;

SyncApiComponentFactory* GetSyncApiComponentFactory() override;

void SetModelTypeSyncBridge(ModelTypeSyncBridge* bridge);