Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6161)

Unified Diff: chrome/browser/sync/chrome_sync_client.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/chrome_sync_client.h ('k') | components/browser_sync/profile_sync_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/chrome_sync_client.cc
diff --git a/chrome/browser/sync/chrome_sync_client.cc b/chrome/browser/sync/chrome_sync_client.cc
index 2223129388be013af1233a9b88dab924d2b7e459..2aa52e98db278d8e3dc9bde8f6a0035d5e04c1ca 100644
--- a/chrome/browser/sync/chrome_sync_client.cc
+++ b/chrome/browser/sync/chrome_sync_client.cc
@@ -441,36 +441,34 @@ ChromeSyncClient::GetSyncBridgeForModelType(syncer::ModelType type) {
}
scoped_refptr<syncer::ModelSafeWorker>
-ChromeSyncClient::CreateModelWorkerForGroup(
- syncer::ModelSafeGroup group,
- syncer::WorkerLoopDestructionObserver* observer) {
+ChromeSyncClient::CreateModelWorkerForGroup(syncer::ModelSafeGroup group) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
switch (group) {
case syncer::GROUP_DB:
return new syncer::BrowserThreadModelWorker(
BrowserThread::GetTaskRunnerForThread(BrowserThread::DB),
- syncer::GROUP_DB, observer);
+ syncer::GROUP_DB);
case syncer::GROUP_FILE:
return new syncer::BrowserThreadModelWorker(
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE),
- syncer::GROUP_FILE, observer);
+ syncer::GROUP_FILE);
case syncer::GROUP_UI:
return new syncer::UIModelWorker(
- BrowserThread::GetTaskRunnerForThread(BrowserThread::UI), observer);
+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI));
case syncer::GROUP_PASSIVE:
- return new syncer::PassiveModelWorker(observer);
+ return new syncer::PassiveModelWorker();
case syncer::GROUP_HISTORY: {
history::HistoryService* history_service = GetHistoryService();
if (!history_service)
return nullptr;
return new HistoryModelWorker(
history_service->AsWeakPtr(),
- BrowserThread::GetTaskRunnerForThread(BrowserThread::UI), observer);
+ BrowserThread::GetTaskRunnerForThread(BrowserThread::UI));
}
case syncer::GROUP_PASSWORD: {
if (!password_store_.get())
return nullptr;
- return new PasswordModelWorker(password_store_, observer);
+ return new PasswordModelWorker(password_store_);
}
default:
return nullptr;
« no previous file with comments | « chrome/browser/sync/chrome_sync_client.h ('k') | components/browser_sync/profile_sync_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698