components/sync/tools/sync_client.cc - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/tools/sync_client.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: CR maxbogue #22 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/tools/sync_client.cc

diff --git a/components/sync/tools/sync_client.cc b/components/sync/tools/sync_client.cc

index 87356b9038d41294d0816a86ea6c3a0470981fbc..69954bca77b5c59e113ce9f4b7da26a9cf52c4b1 100644

--- a/components/sync/tools/sync_client.cc

+++ b/components/sync/tools/sync_client.cc

@@ -383,7 +383,7 @@ int SyncClientMain(int argc, char* argv[]) {

routing_info[it.Get()] = GROUP_PASSIVE;

}

scoped_refptr<PassiveModelWorker> passive_model_safe_worker =

- new PassiveModelWorker(nullptr);

+ new PassiveModelWorker();

std::vector<scoped_refptr<ModelSafeWorker>> workers;

workers.push_back(passive_model_safe_worker);