components/sync/driver/glue/browser_thread_model_worker_unittest.cc - Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/glue/browser_thread_model_worker_unittest.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)

Patch Set: self-review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/driver/glue/browser_thread_model_worker.cc ('k') | components/sync/driver/glue/sync_backend_host_impl.cc » ('j') | components/sync/driver/glue/sync_backend_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/driver/glue/browser_thread_model_worker_unittest.cc

diff --git a/components/sync/driver/glue/browser_thread_model_worker_unittest.cc b/components/sync/driver/glue/browser_thread_model_worker_unittest.cc

index 6ed62bb66fb4dac10e997a0c30b82eafdee804a3..e40466a0e2c6ca4963f1fb1c81f4e9a595c74172 100644

--- a/components/sync/driver/glue/browser_thread_model_worker_unittest.cc

+++ b/components/sync/driver/glue/browser_thread_model_worker_unittest.cc

@@ -68,8 +68,7 @@ class SyncBrowserThreadModelWorkerTest : public testing::Test {

protected:

void SetUp() override {

db_thread_.Start();

- worker_ = new BrowserThreadModelWorker(db_thread_.task_runner(), GROUP_DB,

- nullptr);

+ worker_ = new BrowserThreadModelWorker(db_thread_.task_runner(), GROUP_DB);

}

virtual void Teardown() {