Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: ios/chrome/browser/sync/ios_chrome_sync_client.mm

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/sync/ios_chrome_sync_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/sync/ios_chrome_sync_client.h" 5 #include "ios/chrome/browser/sync/ios_chrome_sync_client.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 browser_state_) 335 browser_state_)
336 ->GetDeviceInfoSyncBridge() 336 ->GetDeviceInfoSyncBridge()
337 ->AsWeakPtr(); 337 ->AsWeakPtr();
338 default: 338 default:
339 NOTREACHED(); 339 NOTREACHED();
340 return base::WeakPtr<syncer::ModelTypeSyncBridge>(); 340 return base::WeakPtr<syncer::ModelTypeSyncBridge>();
341 } 341 }
342 } 342 }
343 343
344 scoped_refptr<syncer::ModelSafeWorker> 344 scoped_refptr<syncer::ModelSafeWorker>
345 IOSChromeSyncClient::CreateModelWorkerForGroup( 345 IOSChromeSyncClient::CreateModelWorkerForGroup(syncer::ModelSafeGroup group) {
346 syncer::ModelSafeGroup group,
347 syncer::WorkerLoopDestructionObserver* observer) {
348 DCHECK_CURRENTLY_ON(web::WebThread::UI); 346 DCHECK_CURRENTLY_ON(web::WebThread::UI);
349 switch (group) { 347 switch (group) {
350 case syncer::GROUP_DB: 348 case syncer::GROUP_DB:
351 return new syncer::BrowserThreadModelWorker( 349 return new syncer::BrowserThreadModelWorker(
352 web::WebThread::GetTaskRunnerForThread(web::WebThread::DB), 350 web::WebThread::GetTaskRunnerForThread(web::WebThread::DB),
353 syncer::GROUP_DB, observer); 351 syncer::GROUP_DB);
354 case syncer::GROUP_FILE: 352 case syncer::GROUP_FILE:
355 return new syncer::BrowserThreadModelWorker( 353 return new syncer::BrowserThreadModelWorker(
356 web::WebThread::GetTaskRunnerForThread(web::WebThread::FILE), 354 web::WebThread::GetTaskRunnerForThread(web::WebThread::FILE),
357 syncer::GROUP_FILE, observer); 355 syncer::GROUP_FILE);
358 case syncer::GROUP_UI: 356 case syncer::GROUP_UI:
359 return new syncer::UIModelWorker( 357 return new syncer::UIModelWorker(
360 web::WebThread::GetTaskRunnerForThread(web::WebThread::UI), observer); 358 web::WebThread::GetTaskRunnerForThread(web::WebThread::UI));
361 case syncer::GROUP_PASSIVE: 359 case syncer::GROUP_PASSIVE:
362 return new syncer::PassiveModelWorker(observer); 360 return new syncer::PassiveModelWorker();
363 case syncer::GROUP_HISTORY: { 361 case syncer::GROUP_HISTORY: {
364 history::HistoryService* history_service = GetHistoryService(); 362 history::HistoryService* history_service = GetHistoryService();
365 if (!history_service) 363 if (!history_service)
366 return nullptr; 364 return nullptr;
367 return new browser_sync::HistoryModelWorker( 365 return new browser_sync::HistoryModelWorker(
368 history_service->AsWeakPtr(), 366 history_service->AsWeakPtr(),
369 web::WebThread::GetTaskRunnerForThread(web::WebThread::UI), observer); 367 web::WebThread::GetTaskRunnerForThread(web::WebThread::UI));
370 } 368 }
371 case syncer::GROUP_PASSWORD: { 369 case syncer::GROUP_PASSWORD: {
372 if (!password_store_) 370 if (!password_store_)
373 return nullptr; 371 return nullptr;
374 return new browser_sync::PasswordModelWorker(password_store_, observer); 372 return new browser_sync::PasswordModelWorker(password_store_);
375 } 373 }
376 default: 374 default:
377 return nullptr; 375 return nullptr;
378 } 376 }
379 } 377 }
380 378
381 syncer::SyncApiComponentFactory* 379 syncer::SyncApiComponentFactory*
382 IOSChromeSyncClient::GetSyncApiComponentFactory() { 380 IOSChromeSyncClient::GetSyncApiComponentFactory() {
383 return component_factory_.get(); 381 return component_factory_.get();
384 } 382 }
(...skipping 16 matching lines...) Expand all
401 IOSChromeProfileSyncServiceFactory::GetForBrowserState(browser_state); 399 IOSChromeProfileSyncServiceFactory::GetForBrowserState(browser_state);
402 if (profile_sync_service != nullptr) { 400 if (profile_sync_service != nullptr) {
403 const syncer::DeviceInfoTracker* tracker = 401 const syncer::DeviceInfoTracker* tracker =
404 profile_sync_service->GetDeviceInfoTracker(); 402 profile_sync_service->GetDeviceInfoTracker();
405 if (tracker != nullptr) { 403 if (tracker != nullptr) {
406 trackers->push_back(tracker); 404 trackers->push_back(tracker);
407 } 405 }
408 } 406 }
409 } 407 }
410 } 408 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/sync/ios_chrome_sync_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698