Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: components/sync/test/engine/fake_model_worker.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/test/engine/fake_model_worker.h ('k') | components/sync/tools/sync_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/test/engine/fake_model_worker.h" 5 #include "components/sync/test/engine/fake_model_worker.h"
6 6
7 #include "base/callback.h"
8
7 namespace syncer { 9 namespace syncer {
8 10
9 FakeModelWorker::FakeModelWorker(ModelSafeGroup group) 11 FakeModelWorker::FakeModelWorker(ModelSafeGroup group) : group_(group) {}
10 : ModelSafeWorker(nullptr), group_(group) {}
11 12
12 FakeModelWorker::~FakeModelWorker() { 13 FakeModelWorker::~FakeModelWorker() {
13 // We may need to relax this is FakeModelWorker is used in a 14 // We may need to relax this is FakeModelWorker is used in a
14 // multi-threaded test; since ModelSafeWorkers are 15 // multi-threaded test; since ModelSafeWorkers are
15 // RefCountedThreadSafe, they could theoretically be destroyed from 16 // RefCountedThreadSafe, they could theoretically be destroyed from
16 // a different thread. 17 // a different thread.
17 DCHECK(CalledOnValidThread()); 18 DCHECK(CalledOnValidThread());
18 } 19 }
19 20
20 void FakeModelWorker::RegisterForLoopDestruction() {
21 NOTREACHED();
22 }
23
24 SyncerError FakeModelWorker::DoWorkAndWaitUntilDoneImpl( 21 SyncerError FakeModelWorker::DoWorkAndWaitUntilDoneImpl(
25 const WorkCallback& work) { 22 const WorkCallback& work) {
26 DCHECK(CalledOnValidThread()); 23 DCHECK(CalledOnValidThread());
27 // Simply do the work on the current thread. 24 // Simply do the work on the current thread.
28 return work.Run(); 25 return work.Run();
29 } 26 }
30 27
31 ModelSafeGroup FakeModelWorker::GetModelSafeGroup() { 28 ModelSafeGroup FakeModelWorker::GetModelSafeGroup() {
32 DCHECK(CalledOnValidThread()); 29 DCHECK(CalledOnValidThread());
33 return group_; 30 return group_;
34 } 31 }
35 32
36 } // namespace syncer 33 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync/test/engine/fake_model_worker.h ('k') | components/sync/tools/sync_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698