Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: components/sync/driver/glue/sync_backend_host_impl_unittest.cc

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/driver/glue/sync_backend_host_impl.h" 5 #include "components/sync/driver/glue/sync_backend_host_impl.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 private: 135 private:
136 ModelTypeSet initial_sync_ended_types_; 136 ModelTypeSet initial_sync_ended_types_;
137 ModelTypeSet progress_marker_types_; 137 ModelTypeSet progress_marker_types_;
138 ModelTypeSet configure_fail_types_; 138 ModelTypeSet configure_fail_types_;
139 FakeSyncManager** fake_manager_; 139 FakeSyncManager** fake_manager_;
140 }; 140 };
141 141
142 class BackendSyncClient : public FakeSyncClient { 142 class BackendSyncClient : public FakeSyncClient {
143 public: 143 public:
144 scoped_refptr<ModelSafeWorker> CreateModelWorkerForGroup( 144 scoped_refptr<ModelSafeWorker> CreateModelWorkerForGroup(
145 ModelSafeGroup group, 145 ModelSafeGroup group) override {
146 WorkerLoopDestructionObserver* observer) override {
147 switch (group) { 146 switch (group) {
148 case GROUP_PASSIVE: 147 case GROUP_PASSIVE:
149 return new PassiveModelWorker(observer); 148 return new PassiveModelWorker();
150 default: 149 default:
151 return nullptr; 150 return nullptr;
152 } 151 }
153 } 152 }
154 }; 153 };
155 154
156 class SyncBackendHostTest : public testing::Test { 155 class SyncBackendHostTest : public testing::Test {
157 protected: 156 protected:
158 SyncBackendHostTest() : fake_manager_(nullptr) {} 157 SyncBackendHostTest() : fake_manager_(nullptr) {}
159 158
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 backend_->StopSyncingForShutdown(); 829 backend_->StopSyncingForShutdown();
831 // Verify that call to DeactivateNonBlockingDataType doesn't assert. 830 // Verify that call to DeactivateNonBlockingDataType doesn't assert.
832 backend_->DeactivateNonBlockingDataType(AUTOFILL); 831 backend_->DeactivateNonBlockingDataType(AUTOFILL);
833 backend_->Shutdown(STOP_SYNC); 832 backend_->Shutdown(STOP_SYNC);
834 backend_.reset(); 833 backend_.reset();
835 } 834 }
836 835
837 } // namespace 836 } // namespace
838 837
839 } // namespace syncer 838 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync/driver/glue/sync_backend_host_impl.cc ('k') | components/sync/driver/glue/sync_backend_registrar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698