Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Side by Side Diff: chrome/browser/sync/chrome_sync_client.h

Issue 2471183003: Do not observe MessageLoop destruction from ModelSafeWorker. (Closed)
Patch Set: CR maxbogue #23 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/chrome_sync_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__ 5 #ifndef CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__
6 #define CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__ 6 #define CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 autofill::PersonalDataManager* GetPersonalDataManager() override; 48 autofill::PersonalDataManager* GetPersonalDataManager() override;
49 invalidation::InvalidationService* GetInvalidationService() override; 49 invalidation::InvalidationService* GetInvalidationService() override;
50 BookmarkUndoService* GetBookmarkUndoServiceIfExists() override; 50 BookmarkUndoService* GetBookmarkUndoServiceIfExists() override;
51 scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() override; 51 scoped_refptr<syncer::ExtensionsActivity> GetExtensionsActivity() override;
52 sync_sessions::SyncSessionsClient* GetSyncSessionsClient() override; 52 sync_sessions::SyncSessionsClient* GetSyncSessionsClient() override;
53 base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 53 base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
54 syncer::ModelType type) override; 54 syncer::ModelType type) override;
55 base::WeakPtr<syncer::ModelTypeSyncBridge> GetSyncBridgeForModelType( 55 base::WeakPtr<syncer::ModelTypeSyncBridge> GetSyncBridgeForModelType(
56 syncer::ModelType type) override; 56 syncer::ModelType type) override;
57 scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup( 57 scoped_refptr<syncer::ModelSafeWorker> CreateModelWorkerForGroup(
58 syncer::ModelSafeGroup group, 58 syncer::ModelSafeGroup group) override;
59 syncer::WorkerLoopDestructionObserver* observer) override;
60 syncer::SyncApiComponentFactory* GetSyncApiComponentFactory() override; 59 syncer::SyncApiComponentFactory* GetSyncApiComponentFactory() override;
61 60
62 // Helpers for overriding getters in tests. 61 // Helpers for overriding getters in tests.
63 void SetSyncApiComponentFactoryForTesting( 62 void SetSyncApiComponentFactoryForTesting(
64 std::unique_ptr<syncer::SyncApiComponentFactory> component_factory); 63 std::unique_ptr<syncer::SyncApiComponentFactory> component_factory);
65 64
66 // Iterates over all of the profiles that have been loaded so far, and 65 // Iterates over all of the profiles that have been loaded so far, and
67 // extracts their tracker if present. If some profiles don't have trackers, no 66 // extracts their tracker if present. If some profiles don't have trackers, no
68 // indication is given in the passed vector. 67 // indication is given in the passed vector.
69 static void GetDeviceInfoTrackers( 68 static void GetDeviceInfoTrackers(
(...skipping 30 matching lines...) Expand all
100 ExtensionsActivityMonitor extensions_activity_monitor_; 99 ExtensionsActivityMonitor extensions_activity_monitor_;
101 100
102 base::WeakPtrFactory<ChromeSyncClient> weak_ptr_factory_; 101 base::WeakPtrFactory<ChromeSyncClient> weak_ptr_factory_;
103 102
104 DISALLOW_COPY_AND_ASSIGN(ChromeSyncClient); 103 DISALLOW_COPY_AND_ASSIGN(ChromeSyncClient);
105 }; 104 };
106 105
107 } // namespace browser_sync 106 } // namespace browser_sync
108 107
109 #endif // CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__ 108 #endif // CHROME_BROWSER_SYNC_CHROME_SYNC_CLIENT_H__
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/chrome_sync_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698