Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/public/platform/WebViewScheduler.h

Issue 2471153002: [scheduler] Use Finch to control background throttling. (Closed)
Patch Set: Address skyostil@'s comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebViewScheduler.h
diff --git a/third_party/WebKit/public/platform/WebViewScheduler.h b/third_party/WebKit/public/platform/WebViewScheduler.h
index ae94ab88081f36df642d90e7d11562c81d4b5d25..55f61844efb87adf1e1d4e371c783616923df865 100644
--- a/third_party/WebKit/public/platform/WebViewScheduler.h
+++ b/third_party/WebKit/public/platform/WebViewScheduler.h
@@ -16,6 +16,18 @@ class WebFrameScheduler;
class BLINK_PLATFORM_EXPORT WebViewScheduler {
public:
+ // Helper interface to plumb settings from WebSettings to scheduler.
+ class BLINK_PLATFORM_EXPORT WebViewSchedulerSettings {
Sami 2016/11/07 16:33:42 nit: To improve readability how about just calling
altimin 2016/11/07 17:01:33 I considered doing this, but given that WebViewImp
Sami 2016/11/07 17:08:34 Hmm, it will inherit WebViewScheduler::Settings, n
altimin 2016/11/07 17:10:29 My understanding is that Settings inside WebViewSc
+ public:
+ virtual ~WebViewSchedulerSettings() {}
+
+ // Background throttling aggressiveness settings.
+ virtual float expensiveBackgroundThrottlingCPUBudget() = 0;
+ virtual float expensiveBackgroundThrottlingInitialBudget() = 0;
+ virtual float expensiveBackgroundThrottlingMaxBudget() = 0;
+ virtual float expensiveBackgroundThrottlingMaxDelay() = 0;
+ };
+
virtual ~WebViewScheduler() {}
// The scheduler may throttle tasks associated with background pages.

Powered by Google App Engine
This is Rietveld 408576698