third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc - Issue 2471153002: [scheduler] Use Finch to control background throttling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2471153002: [scheduler] Use Finch to control background throttling. (Closed)

Patch Set: Fix test and address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc ('k') | third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

index 2fd037b1947d5d392f5635cc0acdcccdca8a796c..a883c1466a25659f5b6bdf6f42fa4b3144f12ca5 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

@@ -38,8 +38,9 @@ class WebViewSchedulerImplTest : public testing::Test {

delegate_ = SchedulerTqmDelegateForTest::Create(

mock_task_runner_, base::MakeUnique<TestTimeSource>(clock_.get()));

scheduler_.reset(new RendererSchedulerImpl(delegate_));

- web_view_scheduler_.reset(new WebViewSchedulerImpl(

- nullptr, scheduler_.get(), DisableBackgroundTimerThrottling()));

+ web_view_scheduler_.reset(

+ new WebViewSchedulerImpl(nullptr, nullptr, scheduler_.get(),

+ DisableBackgroundTimerThrottling()));

web_frame_scheduler_ =

web_view_scheduler_->createWebFrameSchedulerImpl(nullptr);

}

@@ -137,7 +138,7 @@ TEST_F(WebViewSchedulerImplTest, RepeatingLoadingTask_PageInBackground) {

TEST_F(WebViewSchedulerImplTest, RepeatingTimers_OneBackgroundOneForeground) {

std::unique_ptr<WebViewSchedulerImpl> web_view_scheduler2(

- new WebViewSchedulerImpl(nullptr, scheduler_.get(), false));

+ new WebViewSchedulerImpl(nullptr, nullptr, scheduler_.get(), false));

std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler2 =

web_view_scheduler2->createWebFrameSchedulerImpl(nullptr);