Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2471133004: Add PopularSites test. (Closed)

Created:
4 years, 1 month ago by sfiera
Modified:
4 years, 1 month ago
Reviewers:
markusheintz_
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PopularSites test. There's a lot more here that ought to be tested, but this is a start. Committed: https://crrev.com/acc10b6277fd92780214c318a06e1a7a576f2b6d Cr-Commit-Position: refs/heads/master@{#430262}

Patch Set 1 #

Patch Set 2 : Finish test. #

Patch Set 3 : Polish. #

Total comments: 1

Patch Set 4 : Add test deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -0 lines) Patch
M components/ntp_tiles/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A components/ntp_tiles/popular_sites_unittest.cc View 1 2 1 chunk +224 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sfiera
You get all my reviews this week.
4 years, 1 month ago (2016-11-04 10:44:17 UTC) #2
markusheintz_
LGTM https://codereview.chromium.org/2471133004/diff/40001/components/ntp_tiles/popular_sites_unittest.cc File components/ntp_tiles/popular_sites_unittest.cc (right): https://codereview.chromium.org/2471133004/diff/40001/components/ntp_tiles/popular_sites_unittest.cc#newcode52 components/ntp_tiles/popular_sites_unittest.cc:52: // Copied from iOS code. Perhaps should be ...
4 years, 1 month ago (2016-11-04 14:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471133004/40001
4 years, 1 month ago (2016-11-07 12:04:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/310039)
4 years, 1 month ago (2016-11-07 12:07:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471133004/60001
4 years, 1 month ago (2016-11-07 12:31:56 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-07 13:34:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 13:36:04 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/acc10b6277fd92780214c318a06e1a7a576f2b6d
Cr-Commit-Position: refs/heads/master@{#430262}

Powered by Google App Engine
This is Rietveld 408576698