Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: src/core/SkXfermode.cpp

Issue 2471133002: Set analytic AA as default. (Closed)
Patch Set: Turn some asserts off due to srgb issues Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkSRGB.h ('K') | « src/core/SkScan.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkXfermode.cpp
diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp
index 8632fdfe56cc56dde33662ba16047469bcee8b6e..1963ce85df26af9be1fc6acfafb23244b65e5837 100644
--- a/src/core/SkXfermode.cpp
+++ b/src/core/SkXfermode.cpp
@@ -949,7 +949,8 @@ template <Sk4f (blend)(const Sk4f&, const Sk4f&)> SkPM4f proc_4f(const SkPM4f& s
assert_unit(s);
assert_unit(d);
SkPM4f r = as_pm4f(blend(as_4f(s), as_4f(d)));
- assert_unit(r);
+ // Turn this assert off for now because srgb conversions may end up in rgb > a
+ // assert_unit(r);
mtklein_C 2016/11/02 18:48:19 I'm hoping to obsolete this code over time so I do
return r;
}
« src/core/SkSRGB.h ('K') | « src/core/SkScan.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698