src/core/SkXfermode.cpp - Issue 2471133002: Set analytic AA as default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkXfermode.cpp

Issue 2471133002: Set analytic AA as default. (Closed)

Patch Set: One more catch Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkXfermode.cpp

diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp

index 8632fdfe56cc56dde33662ba16047469bcee8b6e..1963ce85df26af9be1fc6acfafb23244b65e5837 100644

--- a/src/core/SkXfermode.cpp

+++ b/src/core/SkXfermode.cpp

@@ -949,7 +949,8 @@ template <Sk4f (blend)(const Sk4f&, const Sk4f&)> SkPM4f proc_4f(const SkPM4f& s

assert_unit(s);

assert_unit(d);

SkPM4f r = as_pm4f(blend(as_4f(s), as_4f(d)));

- assert_unit(r);

+ // Turn this assert off for now because srgb conversions may end up in rgb > a

+ // assert_unit(r);

return r;

}