Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2471133002: Set analytic AA as default. (Closed)

Created:
4 years, 1 month ago by liyuqian
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set analytic AA as default. We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using analytic AA until we fix all the Chrome tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002 Committed: https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8 Committed: https://skia.googlesource.com/skia/+/bfebe22ed54d1e3a00888292f10ed8b9714135d3

Patch Set 1 #

Patch Set 2 : Turn some asserts off due to srgb issues #

Total comments: 3

Patch Set 3 : Convexity Test #

Patch Set 4 : Transformation may change convexity #

Patch Set 5 : Fix the 254 alpha issue #

Patch Set 6 : One more catch #

Total comments: 8

Patch Set 7 : Merge and revise. #

Patch Set 8 : Add parsedpaths to expected failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -17 lines) Patch
M infra/bots/recipes/swarm_test.py View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-GalaxyS7-GPU-Adreno530-arm64-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus10-GPU-MaliT604-arm-Release-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus6-GPU-Adreno420-arm-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus9-CPU-Denver-arm64-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-PixelC-GPU-TegraX1-arm64-Debug-GN_Android.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 5 6 7 3 chunks +12 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/nobuildbot.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/recipe_with_gerrit_patch.json View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkAntiRun.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkScan.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkScan_AAAPath.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 57 (41 generated)
liyuqian
4 years, 1 month ago (2016-11-02 14:21:54 UTC) #4
reed1
lgtm
4 years, 1 month ago (2016-11-02 14:23:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471133002/1
4 years, 1 month ago (2016-11-02 16:06:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/2505)
4 years, 1 month ago (2016-11-02 16:12:23 UTC) #9
liyuqian
Please check the two asserts that I removed due to the srgb issue.
4 years, 1 month ago (2016-11-02 18:23:38 UTC) #11
mtklein_C
https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h File src/core/SkSRGB.h (right): https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h#newcode65 src/core/SkSRGB.h:65: // SkASSERTF(0.0f <= f[i] && f[i] < 256.0f, "f[%d] ...
4 years, 1 month ago (2016-11-02 18:48:19 UTC) #17
liyuqian
https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h File src/core/SkSRGB.h (right): https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h#newcode65 src/core/SkSRGB.h:65: // SkASSERTF(0.0f <= f[i] && f[i] < 256.0f, "f[%d] ...
4 years, 1 month ago (2016-11-02 19:33:11 UTC) #18
liyuqian
Hi everyone, I added a bunch of new things after Mike's initial LGTM. How do ...
4 years, 1 month ago (2016-11-07 14:38:31 UTC) #31
reed1
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h File src/core/SkAntiRun.h (right): https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h#newcode25 src/core/SkAntiRun.h:25: static inline SkAlpha CatchOverflow(int alpha) { nit: SkASSERT(alpha >= ...
4 years, 1 month ago (2016-11-07 15:31:43 UTC) #32
liyuqian
Thanks for the comments! Please see the responses below. https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h File src/core/SkAntiRun.h (right): https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h#newcode25 src/core/SkAntiRun.h:25: ...
4 years, 1 month ago (2016-11-07 16:08:00 UTC) #33
liyuqian
On 2016/11/07 16:08:00, liyuqian wrote: > Thanks for the comments! Please see the responses below. ...
4 years, 1 month ago (2016-11-11 20:35:38 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471133002/140001
4 years, 1 month ago (2016-11-11 21:05:59 UTC) #49
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
4 years, 1 month ago (2016-11-11 21:07:21 UTC) #51
liyuqian
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/2499723002/ by liyuqian@google.com. ...
4 years, 1 month ago (2016-11-11 21:30:35 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471133002/140001
4 years, 1 month ago (2016-11-14 18:46:13 UTC) #55
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 19:17:21 UTC) #57
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/bfebe22ed54d1e3a00888292f10ed8b9714135d3

Powered by Google App Engine
This is Rietveld 408576698