Set analytic AA as default.

Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed: https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
Committed: https://skia.googlesource.com/skia/+/bfebe22ed54d1e3a00888292f10ed8b9714135d3

[liyuqian, 2016-11-02 14:21:19]

Description was changed from

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
==========

to

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002
==========

[liyuqian, 2016-11-02 14:21:43]

Description was changed from

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002
==========

to

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002
==========

[liyuqian, 2016-11-02 14:21:44]

liyuqian@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[reed1, 2016-11-02 14:23:36]

lgtm

[liyuqian, 2016-11-02 16:06:24]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-11-02 16:06:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 16:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 16:12:23]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[liyuqian, 2016-11-02 18:23:03]

liyuqian@google.com changed reviewers:
+ msarett@google.com, mtklein@google.com

[liyuqian, 2016-11-02 18:23:38]

Please check the two asserts that I removed due to the srgb issue.

[liyuqian, 2016-11-02 18:24:48]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 18:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 18:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:36:27]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-11-02 18:48:18]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-11-02 18:48:19]

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h
File src/core/SkSRGB.h (right):

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h#newco...
src/core/SkSRGB.h:65: // SkASSERTF(0.0f <= f[i] && f[i] < 256.0f, "f[%d] was %g,
outside [0,256)\n", i, f[i]);
There's a slightly better solution, which is to delete this function completely,
and edit SkRasterPipeline_opts.h to call sk_linear_to_srgb() instead of
sk_linear_to_srgb_noclamp().

If you don't want to complicate this CL with that, that's fine.  I can land that
change first or as a follow up.

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:953: // assert_unit(r);
I'm hoping to obsolete this code over time so I don't mind just disabling the
assert here.

[liyuqian, 2016-11-02 19:33:11]

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h
File src/core/SkSRGB.h (right):

https://codereview.chromium.org/2471133002/diff/20001/src/core/SkSRGB.h#newco...
src/core/SkSRGB.h:65: // SkASSERTF(0.0f <= f[i] && f[i] < 256.0f, "f[%d] was %g,
outside [0,256)\n", i, f[i]);
On 2016/11/02 18:48:19, mtklein_C wrote:
> There's a slightly better solution, which is to delete this function
completely,
> and edit SkRasterPipeline_opts.h to call sk_linear_to_srgb() instead of
> sk_linear_to_srgb_noclamp().
> 
> If you don't want to complicate this CL with that, that's fine.  I can land
that
> change first or as a follow up.

Thank you! I saw your follow up CL. Feel free to land it first as I'm still
debugging the serialize tests issue.

[liyuqian, 2016-11-03 18:20:44]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 18:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:25:45]

Dry run: Try jobs failed on following builders:
  Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on
master.client.skia.android (JOB_FAILED,
http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)

[liyuqian, 2016-11-04 21:07:19]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:07:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 21:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:11:53]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[liyuqian, 2016-11-04 21:23:19]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:23:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:14:34]

Dry run: This issue passed the CQ dry run.

[liyuqian, 2016-11-07 14:38:31]

Hi everyone, I added a bunch of new things after Mike's initial LGTM. How do you
think about them?

[reed1, 2016-11-07 15:31:43]

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h
File src/core/SkAntiRun.h (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h#n...
src/core/SkAntiRun.h:25: static inline SkAlpha CatchOverflow(int alpha) {
nit:

SkASSERT(alpha >= 0 && alpha <= 256);

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp#ne...
src/core/SkPath.cpp:1745: dst->fConvexity = SkPath::kUnknown_Convexity;
If we're going to leave this in for real, please add a comment and a bug as to
why. This has performance implications so we shouldn't leave this here
unnecessarily.

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
File src/core/SkScan_AAAPath.cpp (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
src/core/SkScan_AAAPath.cpp:87: SkASSERT(alpha + (int)delta <= 256);
why do we have a cast on delta?

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
src/core/SkScan_AAAPath.cpp:484: return (alpha * partialHeight + SK_FixedHalf)
>> 16;
return SkToU8(SkFixedRoundToInt(alpha * partialHeight));

[liyuqian, 2016-11-07 16:08:00]

Thanks for the comments! Please see the responses below.

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h
File src/core/SkAntiRun.h (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h#n...
src/core/SkAntiRun.h:25: static inline SkAlpha CatchOverflow(int alpha) {
On 2016/11/07 15:31:42, reed1 wrote:
> nit:
> 
> SkASSERT(alpha >= 0 && alpha <= 256);

Done.

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp#ne...
src/core/SkPath.cpp:1745: dst->fConvexity = SkPath::kUnknown_Convexity;
On 2016/11/07 15:31:42, reed1 wrote:
> If we're going to leave this in for real, please add a comment and a bug as to
> why. This has performance implications so we shouldn't leave this here
> unnecessarily.

Done.

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
File src/core/SkScan_AAAPath.cpp (right):

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
src/core/SkScan_AAAPath.cpp:87: SkASSERT(alpha + (int)delta <= 256);
On 2016/11/07 15:31:42, reed1 wrote:
> why do we have a cast on delta?

I think that we can also cast alpha to int? If we don't cast either of them,
then SkAlpha is only 8 bits unsigned, which means that we would never trigger
the assert.

https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
src/core/SkScan_AAAPath.cpp:484: return (alpha * partialHeight + SK_FixedHalf)
>> 16;
On 2016/11/07 15:31:42, reed1 wrote:
> return SkToU8(SkFixedRoundToInt(alpha * partialHeight));

Done.

[liyuqian, 2016-11-07 16:08:09]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 16:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 16:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 16:37:57]

Dry run: This issue passed the CQ dry run.

[liyuqian, 2016-11-10 21:43:34]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 21:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:53:47]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[liyuqian, 2016-11-11 20:27:35]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 20:27:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liyuqian, 2016-11-11 20:35:38]

On 2016/11/07 16:08:00, liyuqian wrote:
> Thanks for the comments! Please see the responses below.
> 
> https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h
> File src/core/SkAntiRun.h (right):
> 
>
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkAntiRun.h#n...
> src/core/SkAntiRun.h:25: static inline SkAlpha CatchOverflow(int alpha) {
> On 2016/11/07 15:31:42, reed1 wrote:
> > nit:
> > 
> > SkASSERT(alpha >= 0 && alpha <= 256);
> 
> Done.
> 
> https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp
> File src/core/SkPath.cpp (right):
> 
>
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkPath.cpp#ne...
> src/core/SkPath.cpp:1745: dst->fConvexity = SkPath::kUnknown_Convexity;
> On 2016/11/07 15:31:42, reed1 wrote:
> > If we're going to leave this in for real, please add a comment and a bug as
to
> > why. This has performance implications so we shouldn't leave this here
> > unnecessarily.
> 
> Done.
> 
>
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
> File src/core/SkScan_AAAPath.cpp (right):
> 
>
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
> src/core/SkScan_AAAPath.cpp:87: SkASSERT(alpha + (int)delta <= 256);
> On 2016/11/07 15:31:42, reed1 wrote:
> > why do we have a cast on delta?
> 
> I think that we can also cast alpha to int? If we don't cast either of them,
> then SkAlpha is only 8 bits unsigned, which means that we would never trigger
> the assert.
> 
>
https://codereview.chromium.org/2471133002/diff/100001/src/core/SkScan_AAAPat...
> src/core/SkScan_AAAPath.cpp:484: return (alpha * partialHeight + SK_FixedHalf)
> >> 16;
> On 2016/11/07 15:31:42, reed1 wrote:
> > return SkToU8(SkFixedRoundToInt(alpha * partialHeight));
> 
> Done.

Hi everyone, I'd like to land this today so all Skia trybots can exercise my
code before our painful manual landing to Chrome. If there's anything wrong, I
would like to detect it today so Florin doesn't have to try landing it on
Saturday. I would feel extremely sorry if Florin has to go through another
revert... Does that sound good?

[commit-bot: I haz the power, 2016-11-11 20:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:46:46]

Dry run: This issue passed the CQ dry run.

[liyuqian, 2016-11-11 21:05:47]

The CQ bit was checked by liyuqian@google.com

[liyuqian, 2016-11-11 21:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2471133002/#ps140001
(title: "Add parsedpaths to expected failure")

[commit-bot: I haz the power, 2016-11-11 21:05:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 21:07:20]

Description was changed from

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002
==========

to

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed:
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
==========

[commit-bot: I haz the power, 2016-11-11 21:07:21]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8

[liyuqian, 2016-11-11 21:30:35]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2499723002/ by liyuqian@google.com.

The reason for reverting is: SkASSERT triggered in some perf tests. Roll back..

[liyuqian, 2016-11-14 14:37:36]

Description was changed from

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed:
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
==========

to

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed:
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
==========

[liyuqian, 2016-11-14 18:46:08]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-11-14 18:46:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:17:19]

Description was changed from

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed:
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
==========

to

==========
Set analytic AA as default.

We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using
analytic AA until we fix all the Chrome tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002

Committed:
https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8
Committed:
https://skia.googlesource.com/skia/+/bfebe22ed54d1e3a00888292f10ed8b9714135d3
==========

[commit-bot: I haz the power, 2016-11-14 19:17:21]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/bfebe22ed54d1e3a00888292f10ed8b9714135d3