Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: chrome/browser/extensions/extension_garbage_collector.h

Issue 247113002: [Extension] Protect all installed extension from extension storage GC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update .h comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_garbage_collector.h
diff --git a/chrome/browser/extensions/extension_garbage_collector.h b/chrome/browser/extensions/extension_garbage_collector.h
index a6a769903c0ad88dfacb30733e046a9fd2069c46..e5ed983a069c87e34dd35d27a0e184b2ca43b41f 100644
--- a/chrome/browser/extensions/extension_garbage_collector.h
+++ b/chrome/browser/extensions/extension_garbage_collector.h
@@ -60,9 +60,9 @@ class ExtensionGarbageCollector : public KeyedService, public InstallObserver {
// removed iff there are no pending installations.
void GarbageCollectExtensions();
- // Garbage collects apps/extensions isolated storage, if it is not currently
- // active (i.e. is not in ExtensionRegistry::ENABLED). There is an exception
- // for ephemeral apps, because they can outlive their cache lifetimes.
+ // Garbage collects apps/extensions isolated storage, if it is uninstalled.
awong 2014/04/24 16:42:11 nit: storage, if -> storage if
tzik 2014/04/25 06:29:57 Done.
+ // There is an exception for ephemeral apps, because they can outlive their
awong 2014/04/24 16:42:11 nit: apps, because -> apps because
tzik 2014/04/25 06:29:57 Done.
+ // cache lifetimes.
void GarbageCollectIsolatedStorageIfNeeded();
// The BrowserContext associated with the GarbageCollector.

Powered by Google App Engine
This is Rietveld 408576698