Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471113004:
Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds (Closed)
|
Created:
4 years, 1 month ago by adamk Modified:
4 years, 1 month ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com, Jarin Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionSkip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds
R=machenbach@chromium.org
BUG=v8:5457
NOTRY=true
NOTREECHECKS=true
Committed: https://crrev.com/288d9ffd95c15b5a8496ab9a0ec1b7269250dff2
Cr-Commit-Position: refs/heads/master@{#40747}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 ========== to ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true ==========
lgtm, please just tbr and cq skips like this. I was already offline...
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true ========== to ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true NOTREECHECKS=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true NOTREECHECKS=true ========== to ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true NOTREECHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
On 2016/11/04 07:23:33, machenbach (slow) wrote: > lgtm, please just tbr and cq skips like this. I was already offline... The only reason I didn't is that I'm really unsure what the right way to do complex skips like this is. That is, whether to put it in an existing section, with a complicated SKIP line, or to make a new section for the specific combination. Is this format documented somewhere on the wiki?
Message was sent while issue was closed.
On 2016/11/04 17:18:05, adamk wrote: > On 2016/11/04 07:23:33, machenbach (slow) wrote: > > lgtm, please just tbr and cq skips like this. I was already offline... > > The only reason I didn't is that I'm really unsure what the right way to do > complex skips like this is. That is, whether to put it in an existing section, > with a complicated SKIP line, or to make a new section for the specific > combination. > > Is this format documented somewhere on the wiki? Not really. This rather evolved over time. There is no convention about sections. There is only the restriction that evaluating variants works only for toplevel sections. Most violations should be called by presubmit. Apparently not trailing whitespace :/
Message was sent while issue was closed.
Description was changed from ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true NOTREECHECKS=true ========== to ========== Skip flaky test-api/SetJitCodeEventHandler on turbofan_opt/no_snap builds R=machenbach@chromium.org BUG=v8:5457 NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/288d9ffd95c15b5a8496ab9a0ec1b7269250dff2 Cr-Commit-Position: refs/heads/master@{#40747} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/288d9ffd95c15b5a8496ab9a0ec1b7269250dff2 Cr-Commit-Position: refs/heads/master@{#40747} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
