Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.h

Issue 2471103002: [sensors] Close mock sensor stubs after test is finished (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProxy.h
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.h b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
index 05c7c446b6f7d8a58ec576cd661ee3a616593ddb..53f72d99dcc82f9ca21a046eab4f52dd34da01fb 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.h
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
@@ -82,8 +82,8 @@ class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
// Generic handler for a fatal error.
void handleSensorError(ExceptionCode = UnknownError,
- const String& sanitizedMessage = String(),
- const String& unsanitizedMessage = String());
+ String sanitizedMessage = String(),
Mikhail 2016/11/02 14:30:20 nit: pls add comment like "intentionally copied"
shalamov 2016/11/02 14:55:01 Done.
+ String unsanitizedMessage = String());
void onSensorCreated(device::mojom::blink::SensorInitParamsPtr,
device::mojom::blink::SensorClientRequest);

Powered by Google App Engine
This is Rietveld 408576698