ui/gl/gl_surface_egl.cc - Issue 2471073002: X11: Use CopyFromParent colormap when possible (Reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_surface_egl.cc

Issue 2471073002: X11: Use CopyFromParent colormap when possible (Reland) (Closed)

Patch Set: Fix segfault in Angle Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_surface_egl.cc

diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc

index 1b82c97888c590d26f12d6cc28d7b792a5aa5cea..20f844dd8fbcaf2341df34820f4e1f639ee16509 100644

--- a/ui/gl/gl_surface_egl.cc

+++ b/ui/gl/gl_surface_egl.cc

@@ -149,6 +149,8 @@ EGLDisplay GetPlatformANGLEDisplay(EGLNativeDisplayType native_display,

Visual* visual;

ui::XVisualManager::GetInstance()->ChooseVisualForWindow(

true, &visual, nullptr, nullptr, nullptr);

+ if (visual == CopyFromParent)

Corentin Wallez 2016/11/03 21:16:56 How about making XVisualManager only return CopyFr

+ visual = DefaultVisual(g_display, DefaultScreen(g_display));

display_attribs.push_back(EGL_X11_VISUAL_ID_ANGLE);

display_attribs.push_back(static_cast<EGLint>(XVisualIDFromVisual(visual)));

#endif