Adds DesktopWindowTreeHostMus

Adds DesktopWindowTreeHostMus

I'm also adding a new test target, views_aura_mus_unittests that
will run tests using this class. The test isn't run anywhere yet as
the tests fail because the compositor hookup isn't right yet.

BUG=660994
TEST=none
R=erg@chromium.org

Committed: https://crrev.com/12379cecbc249a0d6fc31375940f58ed5dec591e
Cr-Commit-Position: refs/heads/master@{#429519}

[sky, 2016-11-02 23:07:00]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 23:07:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 23:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 23:23:40]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-11-02 23:34:08]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 23:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2016-11-03 00:21:43]

lgtm

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init.cc
File ui/views/mus/aura_init.cc (right):

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init....
ui/views/mus/aura_init.cc:64: base::WrapUnique(new MusClient(connector,
identity, io_task_runner));
MakeUnique<MusClient>?

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init....
ui/views/mus/aura_init.cc:126: return std::move(window_port);
Are you able to just return the output of MakeUnique instead of assigning to a
local variable first? (Seen here and in a few other places).

[commit-bot: I haz the power, 2016-11-03 00:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 00:50:36]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-03 03:07:52]

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init.cc
File ui/views/mus/aura_init.cc (right):

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init....
ui/views/mus/aura_init.cc:64: base::WrapUnique(new MusClient(connector,
identity, io_task_runner));
On 2016/11/03 00:21:43, Elliot Glaysher wrote:
> MakeUnique<MusClient>?

The constructor is private (AuraInit is friended), so it has to be WrapUnique.

https://codereview.chromium.org/2471033005/diff/60001/ui/views/mus/aura_init....
ui/views/mus/aura_init.cc:126: return std::move(window_port);
On 2016/11/03 00:21:43, Elliot Glaysher wrote:
> Are you able to just return the output of MakeUnique instead of assigning to a
> local variable first? (Seen here and in a few other places).

Because the types differ, no. By that I mean unique_ptr is of type WindowPortMus
but the return value is WindowPort. Some compilers are ok with this, but not
all:(

[sky, 2016-11-03 03:07:59]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-11-03 03:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 03:15:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 03:19:31]

Description was changed from

==========
Adds DesktopWindowTreeHostMus

I'm also adding a new test target, views_aura_mus_unittests that
will run tests using this class. The test isn't run anywhere yet as
the tests fail because the compositor hookup isn't right yet.

BUG=660994
TEST=none
R=erg@chromium.org
==========

to

==========
Adds DesktopWindowTreeHostMus

I'm also adding a new test target, views_aura_mus_unittests that
will run tests using this class. The test isn't run anywhere yet as
the tests fail because the compositor hookup isn't right yet.

BUG=660994
TEST=none
R=erg@chromium.org

Committed: https://crrev.com/12379cecbc249a0d6fc31375940f58ed5dec591e
Cr-Commit-Position: refs/heads/master@{#429519}
==========

[commit-bot: I haz the power, 2016-11-03 03:19:32]

Patchset 4 (id:??) landed as
https://crrev.com/12379cecbc249a0d6fc31375940f58ed5dec591e
Cr-Commit-Position: refs/heads/master@{#429519}