[ignition,modules] Introduce bytecodes for loading/storing module variables.

src/compiler/bytecode-graph-builder.cc

Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 6f7b374a7599eae1e15008d684b5c0b6fd0f02af..dbcff3938f9f3fec38ab2fdc18b79669bb371b27 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -691,6 +691,9 @@ void BytecodeGraphBuilder::VisitLdaSmi() {
   environment()->BindAccumulator(node);
 }
 
+void BytecodeGraphBuilder::VisitLdaModuleVariable() { UNIMPLEMENTED(); }
+void BytecodeGraphBuilder::VisitStaModuleVariable() { UNIMPLEMENTED(); }

[rmcilroy, 2016/11/03 13:58:06]

Should these just call the runtime function for now rather than crashing (e.g.,
won't the tests fail in --always-opt)?

[neis, 2016/11/03 15:02:25]

Good idea, just did that (and tested it manually).

Currently our module tests never run with --always-opt. I will look into getting
better coverage next week probably.

+
 void BytecodeGraphBuilder::VisitLdaConstant() {
   Node* node =
       jsgraph()->Constant(bytecode_iterator().GetConstantForIndexOperand(0));