[ignition,modules] Introduce bytecodes for loading/storing module variables.

src/compiler/bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-graph-builder.h"
 
 #include "src/ast/ast.h"
 #include "src/ast/scopes.h"
 #include "src/compilation-info.h"
 #include "src/compiler/bytecode-branch-analysis.h"
@@ skipping 673 matching lines @@
 void BytecodeGraphBuilder::VisitLdaZero() {
   Node* node = jsgraph()->ZeroConstant();
   environment()->BindAccumulator(node);
 }
 
 void BytecodeGraphBuilder::VisitLdaSmi() {
   Node* node = jsgraph()->Constant(bytecode_iterator().GetImmediateOperand(0));
   environment()->BindAccumulator(node);
 }
 
+void BytecodeGraphBuilder::VisitLdaModuleVariable() { UNIMPLEMENTED(); }
+void BytecodeGraphBuilder::VisitStaModuleVariable() { UNIMPLEMENTED(); }

[rmcilroy, 2016/11/03 13:58:06]

Should these just call the runtime function for now rather than crashing (e.g.,
won't the tests fail in --always-opt)?

[neis, 2016/11/03 15:02:25]

Good idea, just did that (and tested it manually).

Currently our module tests never run with --always-opt. I will look into getting
better coverage next week probably.

+
 void BytecodeGraphBuilder::VisitLdaConstant() {
   Node* node =
       jsgraph()->Constant(bytecode_iterator().GetConstantForIndexOperand(0));
   environment()->BindAccumulator(node);
 }
 
 void BytecodeGraphBuilder::VisitLdaUndefined() {
   Node* node = jsgraph()->UndefinedConstant();
   environment()->BindAccumulator(node);
 }
@@ skipping 1529 matching lines @@
     source_positions_->set_current_position(it->source_position());
     it->Advance();
   } else {
     DCHECK_GT(it->code_offset(), offset);
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8