Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 2471023004: Lock CrossThreadPersistentRegion while poisoning HeapPages (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index 667a9bd44c9a8f71941ea07607a5892f95a15d57..9c2889ab8f4654174d306014534240ac970cdf9d 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -1137,6 +1137,8 @@ void ThreadState::preSweep() {
#if defined(ADDRESS_SANITIZER)
void ThreadState::poisonAllHeaps() {
+ CrossThreadPersistentRegion::LockScope persistentLock(
+ ProcessHeap::crossThreadPersistentRegion());
// Poisoning all unmarked objects in the other arenas.
for (int i = 1; i < BlinkGC::NumberOfArenas; i++)
m_arenas[i]->poisonArena();
@@ -1147,6 +1149,8 @@ void ThreadState::poisonAllHeaps() {
}
void ThreadState::poisonEagerArena() {
+ CrossThreadPersistentRegion::LockScope persistentLock(
+ ProcessHeap::crossThreadPersistentRegion());
m_arenas[BlinkGC::EagerSweepArenaIndex]->poisonArena();
// CrossThreadPersistents in unmarked objects may be accessed from other
// threads (e.g. in CrossThreadPersistentRegion::shouldTracePersistent) and
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698