Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html

Issue 2471003002: [sensors] Accelerometer sensor bindings implementation (Closed)
Patch Set: Fix mikhail comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/sensor/accelerometer.html ('K') | « third_party/WebKit/LayoutTests/sensor/accelerometer.html ('k') | third_party/WebKit/LayoutTests/sensor/idl-Accelerometer.html » ('j') | third_party/WebKit/Source/modules/sensor/Accelerometer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
diff --git a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html b/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
index c5a0829d700e3c6dbbc6df053ba4ccb50b6f3667..85d6da1ea279c7d2425032da4fa9624cd237bba0 100644
--- a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
+++ b/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
@@ -3,6 +3,7 @@
<script src="../resources/testharnessreport.js"></script>
<script src="../resources/mojo-helpers.js"></script>
<script src="resources/sensor-helpers.js"></script>
+<script src="resources/generic-sensor-tests.js"></script>
<script>
'use strict';
@@ -17,255 +18,9 @@ function update_sensor_reading(buffer) {
buffer[2] = kDefaultReadingValue;
}
-test(() => assert_throws(
- new RangeError(),
- () => new AmbientLightSensor({frequency: -60})),
- 'Test that negative frequency causes exception from constructor.');
-
-sensor_test(sensor => {
- sensor.mockSensorProvider.setGetSensorShouldFail(true);
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if(ambientLightSensor.state == 'errored') {
- resolve();
- }
- };
- });
-}, 'Test that sensor state changes to "errored" when sensor is not supported.');
-
-sensor_test(sensor => {
- sensor.mockSensorProvider.setGetSensorShouldFail(true);
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
- return new Promise((resolve, reject) => {
- ambientLightSensor.onerror = event => {
- assert_equals(ambientLightSensor.state, 'errored');
- console.log(event.error.message);
- assert_equals(event.error.name, 'NotFoundError');
- ambientLightSensor.onerror = null;
- resolve();
- };
-
- });
-}, 'Test that "onerror" is send when sensor is not supported.');
-
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 560});
- ambientLightSensor.start();
-
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => {
- mockSensor.setStartShouldFail(true);
- return mockSensor.addConfigurationCalled(); })
- .then(mockSensor => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onerror = event => {
- assert_equals(ambientLightSensor.state, 'errored');
- assert_equals(event.error.name, 'OperationError');
- ambientLightSensor.onerror = null;
- resolve();
- };
- });
- });
- return testPromise;
-}, 'Test that "onerror" is send when start() call has failed.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 560});
- ambientLightSensor.start();
-
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => { return mockSensor.addConfigurationCalled(); })
- .then(mockSensor => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
-
- if (ambientLightSensor.state === 'active') {
- let configuration = mockSensor.active_sensor_configurations_[0];
- assert_equals(configuration.frequency, 60);
- ambientLightSensor.stop();
- }
- };
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that frequency is capped to 60.0 Hz.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
-
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
- }
- };
- ambientLightSensor.onerror = reject;
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that sensor can be successfully created if sensor is supported.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
-
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
- }
- };
-
- ambientLightSensor.onerror = reject;
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that sensor can be constructed with default configuration.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
-
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => { return mockSensor.addConfigurationCalled(); })
- .then(mockSensor => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
-
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
- }
- };
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that addConfiguration and removeConfiguration is called.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => {
- return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
- })
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
- };
-
- ambientLightSensor.onchange = e => {
- assert_equals(e.reading.illuminance, kDefaultReadingValue);
- ambientLightSensor.stop();
- };
-
- ambientLightSensor.onerror = reject;
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that onChange is called and sensor reading is valid.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => {
- return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
- })
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = () => {
- if (ambientLightSensor.state === 'idle') {
- assert_equals(ambientLightSensor.reading, null);
- resolve(mockSensor);
- }
- }
-
- ambientLightSensor.onchange = e => {
- assert_equals(e.reading.illuminance, kDefaultReadingValue);
- ambientLightSensor.stop();
- }
- ambientLightSensor.onerror = reject;
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that sensor reading is not updated when sensor is stopped.');
-
-sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
- let testPromise = sensor.mockSensorProvider.getCreatedSensor()
- .then(mockSensor => {
- return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
- })
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onchange = e => {
- if (e.reading.illuminance == kDefaultReadingValue) {
- resolve(mockSensor);
- }
- }
- ambientLightSensor.onerror = reject;
- });
- })
- .then((mockSensor) => {
- testRunner.setPageVisibility("hidden");
- return mockSensor.suspendCalled();
- })
- .then((mockSensor) => {
- testRunner.setPageVisibility("visible");
- return mockSensor.resumeCalled();
- })
- .then((mockSensor) => {
- return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = () => {
- if (ambientLightSensor.state === 'idle') {
- resolve(mockSensor);
- }
- }
- ambientLightSensor.stop();
- ambientLightSensor.onerror = reject;
- });
- })
- .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
-
- return testPromise;
-}, 'Test that sensor receives suspend / resume notifications when page'
- +' visibility changes.');
+function verify_sensor_reading(reading) {
+ return reading.illuminance == kDefaultReadingValue;
+}
+runGenericSensorTest(AmbientLightSensor, update_sensor_reading, verify_sensor_reading);
</script>
« third_party/WebKit/LayoutTests/sensor/accelerometer.html ('K') | « third_party/WebKit/LayoutTests/sensor/accelerometer.html ('k') | third_party/WebKit/LayoutTests/sensor/idl-Accelerometer.html » ('j') | third_party/WebKit/Source/modules/sensor/Accelerometer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698