Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/sensor/accelerometer.html

Issue 2471003002: [sensors] Accelerometer sensor bindings implementation (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/sensor/idl-Accelerometer.html » ('j') | third_party/WebKit/Source/modules/sensor/Accelerometer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/sensor/accelerometer.html
diff --git a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html b/third_party/WebKit/LayoutTests/sensor/accelerometer.html
similarity index 57%
copy from third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
copy to third_party/WebKit/LayoutTests/sensor/accelerometer.html
index 29d94cdbb2038c92ef6c8693c3776fd6805f08d0..b5b9e84461a5e4709c21617f0a5702dbb4196b58 100644
--- a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
+++ b/third_party/WebKit/LayoutTests/sensor/accelerometer.html
@@ -10,25 +10,29 @@
if (!window.testRunner)
debug('This test cannot be run without the TestRunner');
-const kDefaultReadingValue = 3.1415;
+const kDefaultReadingX = 1.12345;
+const kDefaultReadingY = 2.12345;
+const kDefaultReadingZ = 3.12345;
function update_sensor_reading(buffer) {
buffer[1] = window.performance.now();
- buffer[2] = kDefaultReadingValue;
+ buffer[2] = kDefaultReadingX;
+ buffer[3] = kDefaultReadingY;
+ buffer[4] = kDefaultReadingZ;
}
test(() => assert_throws(
new RangeError(),
- () => new AmbientLightSensor({frequency: -60})),
+ () => new Accelerometer({frequency: -60})),
'Test that negative frequency causes exception from constructor.');
sensor_test(sensor => {
sensor.mockSensorProvider.setGetSensorShouldFail(true);
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer();
+ accelerometer.start();
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if(ambientLightSensor.state == 'errored') {
+ accelerometer.onstatechange = event => {
+ if(accelerometer.state == 'errored') {
resolve();
}
};
@@ -37,11 +41,11 @@ sensor_test(sensor => {
sensor_test(sensor => {
sensor.mockSensorProvider.setGetSensorShouldFail(true);
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer();
+ accelerometer.start();
return new Promise((resolve, reject) => {
- ambientLightSensor.onerror = event => {
- assert_equals(ambientLightSensor.state, 'errored');
+ accelerometer.onerror = event => {
+ assert_equals(accelerometer.state, 'errored');
console.log(event.error.message);
assert_equals(event.error.name, 'NotFoundError');
resolve();
@@ -52,8 +56,8 @@ sensor_test(sensor => {
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 560});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 560});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => {
@@ -61,8 +65,8 @@ sensor_test(sensor => {
return mockSensor.addConfigurationCalled(); })
.then(mockSensor => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onerror = event => {
- assert_equals(ambientLightSensor.state, 'errored');
+ accelerometer.onerror = event => {
+ assert_equals(accelerometer.state, 'errored');
assert_equals(event.error.name, 'OperationError');
resolve();
};
@@ -72,22 +76,22 @@ sensor_test(sensor => {
}, 'Test that "onerror" is send when start() call has failed.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 560});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 560});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => { return mockSensor.addConfigurationCalled(); })
.then(mockSensor => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
resolve(mockSensor);
}
- if (ambientLightSensor.state === 'active') {
+ if (accelerometer.state === 'active') {
let configuration = mockSensor.active_sensor_configurations_[0];
assert_equals(configuration.frequency, 60);
- ambientLightSensor.stop();
+ accelerometer.stop();
}
};
});
@@ -98,21 +102,21 @@ sensor_test(sensor => {
}, 'Test that frequency is capped to 60.0 Hz.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 60});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
resolve(mockSensor);
}
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
+ if (accelerometer.state === 'active') {
+ accelerometer.stop();
}
};
- ambientLightSensor.onerror = reject;
+ accelerometer.onerror = reject;
});
})
.then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
@@ -121,22 +125,46 @@ sensor_test(sensor => {
}, 'Test that sensor can be successfully created if sensor is supported.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({includeGravity: false});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
+ assert_equals(accelerometer.includesGravity, false);
resolve(mockSensor);
}
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
+ if (accelerometer.state === 'active') {
+ accelerometer.stop();
+ }
+ };
+ accelerometer.onerror = reject;
+ });
+ })
+ .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
+
+ return testPromise;
+}, 'Test that sensor can be successfully created with sensor specific configuration parameter.');
+
+sensor_test(sensor => {
+ let accelerometer = new Accelerometer();
+ accelerometer.start();
+ let testPromise = sensor.mockSensorProvider.getCreatedSensor()
+ .then((mockSensor) => {
+ return new Promise((resolve, reject) => {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
+ resolve(mockSensor);
+ }
+
+ if (accelerometer.state === 'active') {
+ accelerometer.stop();
}
};
- ambientLightSensor.onerror = reject;
+ accelerometer.onerror = reject;
});
})
.then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
@@ -145,20 +173,20 @@ sensor_test(sensor => {
}, 'Test that sensor can be constructed with default configuration.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 60});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => { return mockSensor.addConfigurationCalled(); })
.then(mockSensor => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
resolve(mockSensor);
}
- if (ambientLightSensor.state === 'active') {
- ambientLightSensor.stop();
+ if (accelerometer.state === 'active') {
+ accelerometer.stop();
}
};
});
@@ -169,26 +197,28 @@ sensor_test(sensor => {
}, 'Test that addConfiguration and removeConfiguration is called.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 60});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => {
return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
})
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = event => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = event => {
+ if (accelerometer.state === 'idle') {
resolve(mockSensor);
}
};
- ambientLightSensor.onchange = e => {
- assert_equals(e.reading.illuminance, kDefaultReadingValue);
- ambientLightSensor.stop();
+ accelerometer.onchange = e => {
+ assert_equals(e.reading.x, kDefaultReadingX);
+ assert_equals(e.reading.y, kDefaultReadingY);
+ assert_equals(e.reading.z, kDefaultReadingZ);
+ accelerometer.stop();
};
- ambientLightSensor.onerror = reject;
+ accelerometer.onerror = reject;
});
})
.then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
@@ -197,26 +227,28 @@ sensor_test(sensor => {
}, 'Test that onChange is called and sensor reading is valid.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor({frequency: 60});
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer({frequency: 60});
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => {
return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
})
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = () => {
- if (ambientLightSensor.state === 'idle') {
- assert_equals(ambientLightSensor.reading, null);
+ accelerometer.onstatechange = () => {
+ if (accelerometer.state === 'idle') {
+ assert_equals(accelerometer.reading, null);
resolve(mockSensor);
}
}
- ambientLightSensor.onchange = e => {
- assert_equals(e.reading.illuminance, kDefaultReadingValue);
- ambientLightSensor.stop();
+ accelerometer.onchange = e => {
+ assert_equals(e.reading.x, kDefaultReadingX);
+ assert_equals(e.reading.y, kDefaultReadingY);
+ assert_equals(e.reading.z, kDefaultReadingZ);
+ accelerometer.stop();
}
- ambientLightSensor.onerror = reject;
+ accelerometer.onerror = reject;
});
})
.then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
@@ -225,20 +257,22 @@ sensor_test(sensor => {
}, 'Test that sensor reading is not updated when sensor is stopped.');
sensor_test(sensor => {
- let ambientLightSensor = new AmbientLightSensor();
- ambientLightSensor.start();
+ let accelerometer = new Accelerometer();
+ accelerometer.start();
let testPromise = sensor.mockSensorProvider.getCreatedSensor()
.then(mockSensor => {
return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading);
})
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onchange = e => {
- if (e.reading.illuminance == kDefaultReadingValue) {
+ accelerometer.onchange = e => {
+ if (e.reading.x == kDefaultReadingX &&
+ e.reading.y == kDefaultReadingY &&
+ e.reading.z == kDefaultReadingZ) {
resolve(mockSensor);
}
}
- ambientLightSensor.onerror = reject;
+ accelerometer.onerror = reject;
});
})
.then((mockSensor) => {
@@ -251,13 +285,13 @@ sensor_test(sensor => {
})
.then((mockSensor) => {
return new Promise((resolve, reject) => {
- ambientLightSensor.onstatechange = () => {
- if (ambientLightSensor.state === 'idle') {
+ accelerometer.onstatechange = () => {
+ if (accelerometer.state === 'idle') {
resolve(mockSensor);
}
}
- ambientLightSensor.stop();
- ambientLightSensor.onerror = reject;
+ accelerometer.stop();
+ accelerometer.onerror = reject;
});
})
.then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/sensor/idl-Accelerometer.html » ('j') | third_party/WebKit/Source/modules/sensor/Accelerometer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698