give user notification if bot or task not found

give user notification if bot or task not found

BUG=661396
Committed: https://github.com/luci/luci-py/commit/de13045c54f4d8bd374ebc6319553311e3dd784b

[kjlubick, 2016-11-02 16:55:42]

kjlubick@google.com changed reviewers:
+ jcgregorio@chromium.org, nodir@chromium.org, stephana@chromium.org

[kjlubick, 2016-11-02 16:55:43]

Try it out at
https://2451-eca4dfd-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task...
https://screenshot.googleplex.com/F375bwJ91eN
https://screenshot.googleplex.com/4HnhQQzPxQh

[nodir, 2016-11-02 18:46:29]

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/bot-page-data.html:142:
this.set("bot_exists", false);
what happens if swarming returns a transient error (HTTP 500). Will it behave
like bot does not exist? that's not right.
Can we somehow explicitly check HTTP status here?

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:98: return
Promise.reject(reason);
What is reason? Can a caller check HTTP status code?
i think the _getJsonAsync's comment needs to be updated.

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page-data.html:145:
this.set("task_exists", false);
same here

[kjlubick, 2016-11-03 15:48:35]

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/botpage/bot-page-data.html:142:
this.set("bot_exists", false);
On 2016/11/02 at 18:46:29, nodir wrote:
> what happens if swarming returns a transient error (HTTP 500). Will it behave
like bot does not exist? that's not right.
> Can we somehow explicitly check HTTP status here?

Done.

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:98: return
Promise.reject(reason);
On 2016/11/02 at 18:46:29, nodir wrote:
> What is reason? Can a caller check HTTP status code?
> i think the _getJsonAsync's comment needs to be updated.

reason is (after https://skia-review.googlesource.com/c/4372/ lands) an 
{
status: Number,
reason: String, # error message from the server
}

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page-data.html:145:
this.set("task_exists", false);
On 2016/11/02 at 18:46:29, nodir wrote:
> same here

Done.

[nodir, 2016-11-03 18:34:17]

lgtm

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:98: return
Promise.reject(reason);
On 2016/11/03 15:48:35, kjlubick wrote:
> On 2016/11/02 at 18:46:29, nodir wrote:
> > What is reason? Can a caller check HTTP status code?
> > i think the _getJsonAsync's comment needs to be updated.
> 
> reason is (after https://skia-review.googlesource.com/c/4372/ lands) an 
> {
> status: Number,
> reason: String, # error message from the server
> }

i think it should a part of the comment. The fact that this function uses sk is
an implementation detail and thus it is not obvious that it will have the same
format

https://codereview.chromium.org/2470973003/diff/60001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/60001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page-data.html:145:
sk.errorMessage("Http response: "+ (r.status || " ") + " " + r.response);
space before first "+"?

[kjlubick, 2016-11-03 19:23:55]

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2470973003/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/common/common-behavior.html:98: return
Promise.reject(reason);
On 2016/11/03 at 18:34:16, nodir wrote:
> On 2016/11/03 15:48:35, kjlubick wrote:
> > On 2016/11/02 at 18:46:29, nodir wrote:
> > > What is reason? Can a caller check HTTP status code?
> > > i think the _getJsonAsync's comment needs to be updated.
> > 
> > reason is (after https://skia-review.googlesource.com/c/4372/ lands) an 
> > {
> > status: Number,
> > reason: String, # error message from the server
> > }
> 
> i think it should a part of the comment. The fact that this function uses sk
is an implementation detail and thus it is not obvious that it will have the
same format

Done.

https://codereview.chromium.org/2470973003/diff/60001/appengine/swarming/ui/r...
File appengine/swarming/ui/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2470973003/diff/60001/appengine/swarming/ui/r...
appengine/swarming/ui/res/imp/botpage/bot-page-data.html:145:
sk.errorMessage("Http response: "+ (r.status || " ") + " " + r.response);
On 2016/11/03 at 18:34:17, nodir wrote:
> space before first "+"?

Done.

[kjlubick, 2016-11-03 19:23:55]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-11-03 19:23:56]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2470973003/#ps80001
(title: "clarify docs")

[commit-bot: I haz the power, 2016-11-03 19:24:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 19:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 19:26:58]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/324477a64a68bc10)

[kjlubick, 2016-11-03 19:31:48]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-11-03 19:31:49]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2470973003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-03 19:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 19:35:45]

Description was changed from

==========
give user notification if bot or task not found

BUG=661396
==========

to

==========
give user notification if bot or task not found

BUG=661396

Committed:
https://github.com/luci/luci-py/commit/de13045c54f4d8bd374ebc6319553311e3dd784b
==========

[commit-bot: I haz the power, 2016-11-03 19:35:46]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-py/commit/de13045c54f4d8bd374ebc6319553311e3dd784b